Bug 1473068

Summary:	incorrect usage of bkr workflow-simple should throw meaningful error
Product:	[Retired] Beaker	Reporter:	Anwesha Chatterjee <achatter>
Component:	command line	Assignee:	beaker-dev-list
Status:	CLOSED DUPLICATE	QA Contact:	tools-bugs <tools-bugs>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	develop	CC:	achatter, beaker-dev-list, dcallagh, mjia, rjoost, tools-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1473067	Environment:
Last Closed:	2017-07-21 03:08:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Anwesha Chatterjee 2017-07-20 01:05:19 UTC

+++ This bug was initially created as a clone of Bug #1473067 +++

Description of problem:
The example command in the man page for bkr workflow-simple 
https://beaker-project.org/docs/man/bkr-workflow-simple.html
produces an error 

Version-Release number of selected component (if applicable):
24.3-1.fc25 

How reproducible:
100%

Steps to Reproduce:
1. run bkr workflow-simple

( basically, dont give it any parameters )


Actual results:
XML-RPC fault: <class 'bkr.common.bexceptions.BX'>:Invalid Distro: None

Expected results:
Something more meaningful about what parameters are required

Additional info:
My config for the client is set up for beaker in a box.

Comment 1 Anwesha Chatterjee 2017-07-20 01:16:11 UTC

[Update]
Description of problem:
incorrect usage of the bkr workflow-simple command produces error that isnt meaningful

Comment 2 Anwesha Chatterjee 2017-07-21 03:08:10 UTC


*** This bug has been marked as a duplicate of bug 1473067 ***

Comment 3 Dan Callaghan 2017-07-24 01:22:33 UTC

This doesn't seem like the same problem as bug 1473067, why is it a dupe?

Comment 4 Anwesha Chatterjee 2017-07-24 04:03:17 UTC

Because the code review for bug 1473067 changes the code in this area, I saw that it would be easier to fix the bug described here as it is a pretty minor change - So it isn't a duplicate but is blocked by the previous bug. Which wasnt an option in the dropdown. Should I leave this open, and connect it to the same gerrit review?

Comment 5 Dan Callaghan 2017-08-11 05:21:03 UTC

Okay I getcha. Duping this is fine as long as we note that this is fixed by the other bug's patch:

https://gerrit.beaker-project.org/c/5756

including a test case for the problem described here:

https://gerrit.beaker-project.org/c/5756/10/IntegrationTests/src/bkr/inttest/client/test_workflow_simple.py#28