Bug 1474171
| Summary: | Build konqueror on all architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||||
| Component: | konqueror | Assignee: | Rex Dieter <rdieter> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | kde-sig, lupinix.fedora, rdieter, yselkowi | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature, Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | konqueror-17.12.3-2.fc28 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-03-30 13:12:40 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1474170 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Yaakov Selkowitz
2017-07-24 04:13:01 UTC
Created attachment 1303426 [details] Patch for rawhide Scratch build on all arches: https://koji.fedoraproject.org/koji/taskinfo?taskID=20707457 I'm ok with the proposed changed here, minus the kwebkitpart dependency (we'll need to handle that differently and separate I think) Or, we can wait for kwebkitpart to get sorted out and do it all at once. (In reply to Rex Dieter from comment #2) > I'm ok with the proposed changed here, minus the kwebkitpart dependency > (we'll need to handle that differently and separate I think) > > Or, we can wait for kwebkitpart to get sorted out and do it all at once. Mixed feelings on this. Technically konqueror still functions fine as an all-in-one file manager/viewer/editor with the other KParts (dolphinpart, katepart, okularpart, oktetapart, etc.). OTOH as a web browser it is only minimally usable with only khtmlpart; most modern websites won't display properly with it. However, the thought just occurred to me that, in whatever order we do this, perhaps the webenginepart should be a separate subpackage (which would be Recommended or Required by the konqueror package on %qt5_qtwebengine_arches). Let me know your thoughts on these points and I can respin the patch. Now that kwebkitpart is updated to KF5, how do you want to proceed with this? 1) Separate subpackage for kwebenginepart? 2) Hard or soft dep on kwebkitpart (or kwebenginepart if yes above) depending on arch? I think option 2 seems preferable for now. Looks like will require some patching, konqueror's buildsystem currently considers webengine an required, non-optional, component. That's already part of my patch; I'm rebasing it now for 17.12.3. Created attachment 1411290 [details] Rebased patch for rawhide Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25863006 Thanks, opted for both afterall, may be useful beyond just konqueror. %changelog * Wed Mar 21 2018 Rex Dieter <rdieter> - 17.12.3-2 - make buildable on all archs (#1474171) - -kwebenginepart subpkg konqueror-17.12.3-2.fc28 kwebkitpart-1.4.0-0.1.20180320.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-78b5d65ff2 konqueror-17.12.3-2.fc28, kwebkitpart-1.4.0-0.1.20180320.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-78b5d65ff2 konqueror-17.12.3-2.fc28, kwebkitpart-1.4.0-0.1.20180320.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |