Bug 1474425

Summary:	Review Request: perl-Alien-Build - Build external dependencies for use in CPAN
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Alien-Build-0.95-1.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-21 07:26:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1474333, 1474392, 1474403
Bug Blocks:	1482945

Description Petr Pisar 2017-07-24 15:01:49 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build-0.66-1.fc27.src.rpm
Description:
This package provides tools for building external (non-CPAN) dependencies
for CPAN. It is mainly designed to be used at install time of a CPAN
client, and work closely with Alien::Base which is used at run time.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-08-14 15:01:54 UTC

Please update to the latest version 0.95. 
Alien::Base was merged into this package in 0.67_01.

Comment 2 Petr Pisar 2017-08-17 13:34:01 UTC

Updated package is on these addresses:

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build-0.95-1.fc27.src.rpm

Comment 3 Jitka Plesnikova 2017-08-18 10:30:34 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-Build-0.95-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Alien::Build)
      1 perl(Alien::Build::Interpolate)
      1 perl(Alien::Build::Plugin)
      1 perl(Alien::Build::Util)
      1 perl(Archive::Tar)
      1 perl(Archive::Zip)
      1 perl(base)
      1 perl(Capture::Tiny) >= 0.17
      1 perl(Carp)
      1 perl(Config)
      1 perl(Config::INI::Reader::Multiline)
      1 perl(constant)
      1 perl(DynaLoader)
      1 perl(Env)
      1 perl(Exporter)
      1 perl(ExtUtils::CBuilder)
      1 perl(ExtUtils::ParseXS) >= 3.30
      1 perl(File::Basename)
      1 perl(File::BOM)
      1 perl(File::chdir)
      1 perl(File::Copy)
      1 perl(File::Find)
      1 perl(File::Temp)
      1 perl(File::Which) >= 1.10
      1 perl(JSON::PP)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Module::Load)
      1 perl(overload)
      1 perl(Path::Tiny) >= 0.077
      1 perl(PkgConfig::LibPkgConf::Client) >= 0.04
      1 perl(PkgConfig::LibPkgConf::Util) >= 0.04
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(Test2::API) >= 1.302015
      1 perl(Test2::Require) >= 0.000060
      1 perl(Text::ParseWords) >= 3.26
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
      1 perl(YAML)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add run-require 'perl(FFI::CheckLib)' - lib/Alien/Base.pm:314

$ rpm -qp --provides perl-Alien-Build-0.95-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Alien::Base) = 0.95
      1 perl(Alien::Base::Wrapper) = 0.95
      1 perl(Alien::Build) = 0.95
      1 perl-Alien-Build = 0.95-1.fc27
      1 perl(Alien::Build::CommandSequence) = 0.95
      1 perl(Alien::Build::Interpolate) = 0.95
      1 perl(Alien::Build::Interpolate::Default) = 0.95
      1 perl(Alien::Build::Interpolate::Helper)
      1 perl(Alien::Build::Meta)
      1 perl(Alien::Build::MM) = 0.95
      1 perl(Alien::Build::Plugin) = 0.95
      1 perl(Alien::Build::Plugin::Build::Autoconf) = 0.95
      1 perl(Alien::Build::Plugin::Build::MSYS) = 0.95
      1 perl(Alien::Build::Plugin::Build::SearchDep) = 0.95
      1 perl(Alien::Build::Plugin::Core::Download) = 0.95
      1 perl(Alien::Build::Plugin::Core::FFI) = 0.95
      1 perl(Alien::Build::Plugin::Core::Gather) = 0.95
      1 perl(Alien::Build::Plugin::Core::Legacy) = 0.95
      1 perl(Alien::Build::Plugin::Core::Setup) = 0.95
      1 perl(Alien::Build::Plugin::Decode::DirListing) = 0.95
      1 perl(Alien::Build::Plugin::Decode::DirListingFtpcopy) = 0.95
      1 perl(Alien::Build::Plugin::Decode::HTML) = 0.95
      1 perl(Alien::Build::Plugin::Download::Negotiate) = 0.95
      1 perl(Alien::Build::Plugin::Extract::ArchiveTar) = 0.95
      1 perl(Alien::Build::Plugin::Extract::ArchiveZip) = 0.95
      1 perl(Alien::Build::Plugin::Extract::CommandLine) = 0.95
      1 perl(Alien::Build::Plugin::Extract::Directory) = 0.95
      1 perl(Alien::Build::Plugin::Extract::Negotiate) = 0.95
      1 perl(Alien::Build::Plugin::Fetch::HTTPTiny) = 0.95
      1 perl(Alien::Build::Plugin::Fetch::Local) = 0.95
      1 perl(Alien::Build::Plugin::Fetch::LocalDir) = 0.95
      1 perl(Alien::Build::Plugin::Fetch::LWP) = 0.95
      1 perl(Alien::Build::Plugin::Fetch::NetFTP) = 0.95
      1 perl(Alien::Build::Plugin::Gather::IsolateDynamic) = 0.95
      1 perl(Alien::Build::PluginMeta)
      1 perl(Alien::Build::Plugin::PkgConfig::LibPkgConf) = 0.95
      1 perl(Alien::Build::Plugin::PkgConfig::MakeStatic) = 0.95
      1 perl(Alien::Build::Plugin::PkgConfig::Negotiate) = 0.95
      1 perl(Alien::Build::Plugin::Prefer::SortVersions) = 0.95
      1 perl(Alien::Build::Plugin::Probe::CBuilder) = 0.95
      1 perl(Alien::Build::Plugin::Probe::CommandLine) = 0.95
      1 perl(Alien::Build::rc)
      1 perl(Alien::Build::TempDir)
      1 perl(Alien::Build::Util) = 0.95
      1 perl(Alien::Build::Util::Win32::RegistryDump) = 0.95
      1 perl(alienfile) = 0.95
      1 perl(Alien::Role) = 0.95
      1 perl(Test::Alien) = 0.95
      1 perl(Test::Alien::Build) = 0.95
      1 perl(Test::Alien::CanCompile) = 0.95
      1 perl(Test::Alien::CanCompileCpp) = 0.95
      1 perl(Test::Alien::CanPlatypus) = 0.95
      1 perl(Test::Alien::Run) = 0.95
      1 perl(Test::Alien::Synthetic) = 0.95
Binary provides are Ok.

$ rpmlint ./perl-Alien-Build*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

FIX: There is a new version 0.99. Please update the package.

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved.

Comment 4 Gwyn Ciesla 2017-08-18 11:16:54 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Build

Comment 5 Petr Pisar 2017-08-21 07:26:34 UTC

Thank you for the review. I added the missing dependency. I will upgrade the package in turn.