Bug 1476305

Summary:	Reports type dashboard widgets cannot be minimized
Product:	Red Hat CloudForms Management Engine	Reporter:	Milan Falešník <mfalesni>
Component:	UI - OPS	Assignee:	Milan Falešník <mfalesni>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Milan Falešník <mfalesni>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0	Flags:	mfalesni: automate_bug+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1480589 (view as bug list)		Environment:
Last Closed:	2018-03-06 14:39:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1480589

Description Milan Falešník 2017-07-28 15:02:55 UTC

Description of problem:
As subject says, report type dashboard widgets cannot be minimized due to wrong HTML code in place.

Version-Release number of selected component (if applicable):
5.8.1.5

How reproducible:
always

Steps to Reproduce:
1. Get on the dashboard (after login) and once the table in "Top CPU consumers (weekly)" is present, try minimizing the widget (using the kebab select in top right corner of the widget)

Actual results:
No minimization happens, yet the menu item in the kebab switches to Maximize (which again only flips the menu item)

Expected results:
Widget gets minimized

Additional info:
I identified the issue as this widget has the table placed *outside* of <div class="mc" ...> unlike other widgets which work.

Comment 2 CFME Bot 2017-07-28 15:13:33 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/1782

Comment 4 CFME Bot 2017-07-28 22:13:27 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/1f589f5d1fd93798d77f9ab644460631e8afad8f

commit 1f589f5d1fd93798d77f9ab644460631e8afad8f
Author:     Milan Falešník <mfalesni>
AuthorDate: Fri Jul 28 17:03:53 2017 +0200
Commit:     Milan Falešník <mfalesni>
CommitDate: Fri Jul 28 17:03:53 2017 +0200

    Fix HAML indentation for Report Widget fragment
    
    Missing indentation caused the widget content being outisde of the div.mc which handles minimizing, therefore minimizing and maximizing of the widget did not work.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1476305

 app/views/dashboard/_widget_report.html.haml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comment 6 Milan Falešník 2017-10-11 09:52:35 UTC

Verified in 5.9.0.1