Bug 1476305 - Reports type dashboard widgets cannot be minimized
Reports type dashboard widgets cannot be minimized
Status: POST
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS (Show other bugs)
5.8.0
Unspecified Unspecified
medium Severity medium
: GA
: 5.9.0
Assigned To: Milan Falešník
Milan Falešník
: TestOnly, ZStream
Depends On:
Blocks: 1480589
  Show dependency treegraph
 
Reported: 2017-07-28 11:02 EDT by Milan Falešník
Modified: 2017-08-14 09:43 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1480589 (view as bug list)
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: Bug
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core
mfalesni: automate_bug+


Attachments (Terms of Use)

  None (edit)
Description Milan Falešník 2017-07-28 11:02:55 EDT
Description of problem:
As subject says, report type dashboard widgets cannot be minimized due to wrong HTML code in place.

Version-Release number of selected component (if applicable):
5.8.1.5

How reproducible:
always

Steps to Reproduce:
1. Get on the dashboard (after login) and once the table in "Top CPU consumers (weekly)" is present, try minimizing the widget (using the kebab select in top right corner of the widget)

Actual results:
No minimization happens, yet the menu item in the kebab switches to Maximize (which again only flips the menu item)

Expected results:
Widget gets minimized

Additional info:
I identified the issue as this widget has the table placed *outside* of <div class="mc" ...> unlike other widgets which work.
Comment 4 CFME Bot 2017-07-28 18:13:27 EDT
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/1f589f5d1fd93798d77f9ab644460631e8afad8f

commit 1f589f5d1fd93798d77f9ab644460631e8afad8f
Author:     Milan Falešník <mfalesni@redhat.com>
AuthorDate: Fri Jul 28 17:03:53 2017 +0200
Commit:     Milan Falešník <mfalesni@redhat.com>
CommitDate: Fri Jul 28 17:03:53 2017 +0200

    Fix HAML indentation for Report Widget fragment
    
    Missing indentation caused the widget content being outisde of the div.mc which handles minimizing, therefore minimizing and maximizing of the widget did not work.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1476305

 app/views/dashboard/_widget_report.html.haml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Note You need to log in before you can comment on or make changes to this bug.