Bug 1476616
Summary: | enable libcerf in gnuplot. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dmitri A. Sergatskov <dasergatskov> |
Component: | gnuplot | Assignee: | Pavel Cahyna <pcahyna> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | alst2821, amello, fkluknav, jamatos, mark.shoulson, orion, rdieter |
Target Milestone: | --- | Keywords: | FutureFeature |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-01-07 01:35:39 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1639186 | ||
Bug Blocks: |
Description
Dmitri A. Sergatskov
2017-07-30 18:58:55 UTC
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. On related note gnuplot 5.2.0 has been released: https://sourceforge.net/projects/gnuplot/files/gnuplot/5.2.0/ marking RFE/FutureFeature to avoid auto-close I have submitted libcerf for inclusion in Fedora. I tried to compile gnuplot using the library by Jose Matos. I found that there is a problem and I propose the patch below to fix the problem. The problem is that libcerf defines "cmplx" as # define cmplx double _Complex and there is a clash with "struct cmplx" defined in gp_types.h --- gnuplot-5.2.5/src/gp_types.h~ 2018-10-03 04:40:25.000000000 +0100 +++ gnuplot-5.2.5/src/gp_types.h 2018-10-16 21:35:13.683301020 +0100 @@ -140,7 +140,7 @@ * into one of scanner/internal/standard/util .h, but I've yet to * decide which of them */ -struct cmplx { +struct gp_cmplx { double real, imag; }; @@ -148,7 +148,7 @@ enum DATA_TYPES type; union { int int_val; - struct cmplx cmplx_val; + struct gp_cmplx cmplx_val; char *string_val; char **data_array; struct value *value_array; (In reply to R Mercado from comment #6) > I tried to compile gnuplot using the library by Jose Matos. > > I found that there is a problem and I propose the patch below to fix the > problem. There is an upstream patch (in gnuplot) for this issue: https://github.com/gnuplot/gnuplot/commit/0508c9c59d27cd32529fa2ddfc440a618f6a8cca#diff-2d506530da12533b1582fe5359bb08b1 I see that libcerf passed review request, when it appears in Fedora I'll enable it in gnuplot. Updated package with libcerf support are available at https://copr.fedorainfracloud.org/coprs/pcahyna/gnuplot-updates/. But, the build logs show BUILDSTDERR: checking for LIBCERF... configure: WARNING: BUILDSTDERR: Package requirements (libcerf) were not met: BUILDSTDERR: Package 'libcerf', required by 'virtual:world', not found BUILDSTDERR: Consider adjusting the PKG_CONFIG_PATH environment variable if you BUILDSTDERR: installed software in a non-standard prefix. BUILDSTDERR: Alternatively, you may set the environment variables LIBCERF_CFLAGS BUILDSTDERR: and LIBCERF_LIBS to avoid the need to call pkg-config. BUILDSTDERR: See the pkg-config man page for more details. BUILDSTDERR: checking for library containing cdawson... -lcerf and later cerf() and other special functions from libcerf: yes so, is libcerf support built properly? Can anyone test, please? (In reply to José Matos from comment #7) > (In reply to R Mercado from comment #6) > > I tried to compile gnuplot using the library by Jose Matos. > > > > I found that there is a problem and I propose the patch below to fix the > > problem. > > There is an upstream patch (in gnuplot) for this issue: > > https://github.com/gnuplot/gnuplot/commit/ > 0508c9c59d27cd32529fa2ddfc440a618f6a8cca#diff- > 2d506530da12533b1582fe5359bb08b1 Thanks, the patch is included in the copr builds. (In reply to Pavel Cahyna from comment #9) > > cerf() and other special functions from libcerf: yes > > so, is libcerf support built properly? Can anyone test, please? A friend who uses gnuplot could test, but he would need a fedora 28 package. Could you generate a build for fedora 28 please? Thanks. (In reply to R Mercado from comment #11) > (In reply to Pavel Cahyna from comment #9) > > > > cerf() and other special functions from libcerf: yes > > > > so, is libcerf support built properly? Can anyone test, please? > > A friend who uses gnuplot could test, but he would need a fedora 28 package. > > Could you generate a build for fedora 28 please? > > Thanks. Sure, it is in copr, see above. Hi. I tested a simple plot and it works okay. I am asking in the fedora users and gnuplot-info mailing lists for examples that exercise libcerf. Thanks, Ronaldo Ethan Merit answered my query. Ethan says: ======= Run the scripts complex_trig.dem and cerf.dem provided in the demo directory. Compare the output to the on-line demo collection http://gnuplot.sourceforge.net/demo_5.3/complex_trig.html http://gnuplot.sourceforge.net/demo_5.3/cerf.html ===== I can report that the examples don't work. I also checked that there is a 5.2 version of the demo pages at http://gnuplot.sourceforge.net/demo_5.2/cerf.html A really simple test is to try to plot the "VP" function I paste the output below: =========== gnuplot> plot VP(x,1.53,0.0) undefined function: VP =========== Other test is the faddeeva function =========== gnuplot> plot real( faddeeva(x) ) undefined function: faddeeva =========== However the test of LIBCERF compilation option passes okay ============ gnuplot> if (strstrt(GPVAL_COMPILE_OPTIONS,"+LIBCERF")) { more> print "bu" more> exit; more> } ============ I got Ethan's surname wrong. It's Merritt. Sorry. Note that since libcerf-1.8 they changed scaling of Voigt function so the Voigt profile plots will look different than those on the gnuplot page. See: http://apps.jcns.fz-juelich.de/src/libcerf/CHANGELOG Dmitri. -- libcerf-1.11-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d92a998d87 libcerf-1.11-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb974b5d2a (In reply to Fedora Update System from comment #18) > libcerf-1.11-1.fc29 has been submitted as an update to Fedora 29. > https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb974b5d2a This update is important because: 1) it fixes normalization of the Voigt function, that was broken in libcerf 1.8-1.10; 2) from the Changelog, "Rename type cmplx into _cerf_cmplx to avoid name clash with Gnuplot pre 5.3.". So no need for a separate patch for gnuplot to fix this issue. A Happy New Year for all. :-) libcerf-1.11-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d92a998d87 libcerf-1.11-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb974b5d2a libcerf-1.11-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. libcerf-1.11-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. "If problems still persist,..." This bug, "enable libcerf in gnuplot," is marked CLOSED, yet libcerf is not enabled in gnuplot in Fedora 30, as of 2019-10-08. This is stalled on https://bugzilla.redhat.com/show_bug.cgi?id=1457252, then? Just about 1 year ago, on 2018-10-16, the comment there said "I am going to merge it in a few days unless there are objections." That didn't seem to happen. Just too much workload? I don't (yet) know enough about building rpms and distributions to contribute a patch, but trying to follow up on this. (In reply to Mark from comment #24) > "If problems still persist,..." > This bug, "enable libcerf in gnuplot," is marked CLOSED, yet libcerf is not > enabled in gnuplot in Fedora 30, as of 2019-10-08. This is stalled on > https://bugzilla.redhat.com/show_bug.cgi?id=1457252, then? Just about 1 > year ago, on 2018-10-16, the comment there said "I am going to merge it in a > few days unless there are objections." That didn't seem to happen. Just > too much workload? I don't (yet) know enough about building rpms and > distributions to contribute a patch, but trying to follow up on this. Yes, this bug was closed mistakenly. Please try the code in https://copr.fedorainfracloud.org/coprs/pcahyna/gnuplot-updates/. I will then merge it to the package. I mean, try the builds available there. |