Bug 1478052

Summary:	Review Request: nuvola-app-google-play-music - Google Play integration for Nuvola Player
Product:	[Fedora] Fedora	Reporter:	MartinKG <mgansser>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-16 20:25:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MartinKG 2017-08-03 13:42:35 UTC

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-play-music.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-play-music-5.19-1.fc26.src.rpm

Description: Integration of Google Calendar web app into your linux desktop via Nuvola Apps.

Fedora Account System Username: martinkg


%changelog
* Fri Jul 28 2017 Martin Gansser <martinkg> - 5.19-1
- initial build


rpmlint -i -v nuvola-app-google-play-music.spec /home/martin/rpmbuild/SRPMS/nuvola-app-google-play-music-5.19-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-google-play-music-5.19-1.fc26.noarch.rpm
nuvola-app-google-play-music.spec: I: checking
nuvola-app-google-play-music.spec:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-google-play-music.spec: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar.gz#/nuvola-app-google-play-music-5.19.tar.gz (timeout 10 seconds)
nuvola-app-google-play-music.src: I: checking
nuvola-app-google-play-music.src: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-google-play-music.src: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds)
nuvola-app-google-play-music.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-google-play-music.src: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar.gz#/nuvola-app-google-play-music-5.19.tar.gz (timeout 10 seconds)
nuvola-app-google-play-music.noarch: I: checking
nuvola-app-google-play-music.noarch: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-google-play-music.noarch: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds)
nuvola-app-google-play-music.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppGooglePlayMusic.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error

2 packages and 1 specfiles checked; 0 errors, 5 warnings.

Comment 1 Vít Ondruch 2017-08-08 12:35:26 UTC

I'll take this for a review.

Comment 2 Vít Ondruch 2017-08-08 12:53:56 UTC

* Wrong license in .metainfo.xml
  - The .metainfo.xml should specify just BSD-2-Clause.

Otherwise the package looks good => APPROVED

Comment 3 MartinKG 2017-08-08 15:20:23 UTC

Thanks for the review.

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-play-music.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-play-music-5.19-2.fc26.src.rpm

%changelog
* Tue Aug 08 2017 Martin Gansser <martinkg> - 5.19-2
- correct %%{name}.metainfo.xml

Comment 4 Ralph Bean 2017-08-10 16:57:40 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-google-play-music

Comment 5 Ralph Bean 2017-08-10 16:57:47 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-google-play-music

Comment 6 MartinKG 2017-08-16 20:25:35 UTC

package has been built successfully on f25, f26 and rawhide.