Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-play-music.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-play-music-5.19-1.fc26.src.rpm Description: Integration of Google Calendar web app into your linux desktop via Nuvola Apps. Fedora Account System Username: martinkg %changelog * Fri Jul 28 2017 Martin Gansser <martinkg> - 5.19-1 - initial build rpmlint -i -v nuvola-app-google-play-music.spec /home/martin/rpmbuild/SRPMS/nuvola-app-google-play-music-5.19-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-google-play-music-5.19-1.fc26.noarch.rpm nuvola-app-google-play-music.spec: I: checking nuvola-app-google-play-music.spec:29: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-google-play-music.spec: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar.gz#/nuvola-app-google-play-music-5.19.tar.gz (timeout 10 seconds) nuvola-app-google-play-music.src: I: checking nuvola-app-google-play-music.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-google-play-music.src: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds) nuvola-app-google-play-music.src:29: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-google-play-music.src: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar.gz#/nuvola-app-google-play-music-5.19.tar.gz (timeout 10 seconds) nuvola-app-google-play-music.noarch: I: checking nuvola-app-google-play-music.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-google-play-music.noarch: I: checking-url https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds) nuvola-app-google-play-music.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppGooglePlayMusic.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 5 warnings.
I'll take this for a review.
* Wrong license in .metainfo.xml - The .metainfo.xml should specify just BSD-2-Clause. Otherwise the package looks good => APPROVED
Thanks for the review. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-play-music.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-play-music-5.19-2.fc26.src.rpm %changelog * Tue Aug 08 2017 Martin Gansser <martinkg> - 5.19-2 - correct %%{name}.metainfo.xml
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-google-play-music
package has been built successfully on f25, f26 and rawhide.