Bug 1478855

Summary: When pipeline stage is canceled, stage icon is better to show canceled instead of failed
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Samuel Padgett <spadgett>
Status: CLOSED NOTABUG QA Contact: XiaochuanWang <xiaocwan>
Severity: low Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-07 12:34:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
aborted stage icon
none
Jenkins shows the stage as failed as well none

Description Xingxing Xia 2017-08-07 10:38:17 UTC
Description of problem:
When pipeline stage is canceled, stage icon now is shown failed. It is better to show canceled instead of failed

Version-Release number of selected component (if applicable):
v3.6.173.0.5

How reproducible:
Always

Steps to Reproduce:
1. Create pipeline
$ oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/pipeline/samplepipeline.yaml
2. Define "input" step in jenkinsfile on web console by adding steps 'input message' as stages
...
      jenkinsfile: |-
...
        stage('stage1') {
        input message: 'really approve?'
        }
        stage('stage2') {
        input message: 'really approve?'
        }
...


3. Start pipeline. When web prompts "Input Required", click it and select Abort in following page

4. Check the pipeline build's status icon
Check the aborted stage icon

Actual results:
4. The pipeline build's status icon is shown as canceled.
But the aborted stage icon is shown as failed.
See screenshot. The element inspector shows "FAILED" for canceled stage

Expected results:
4. Both should be shown as canceled, as screenshot in https://github.com/openshift/origin-web-console/pull/188 designed for card https://trello.com/c/VgmHJvYQ/676-1-manual-approval-stages-in-pipelines

Additional info:

Comment 1 Xingxing Xia 2017-08-07 10:38:58 UTC
Created attachment 1310018 [details]
aborted stage icon

Comment 2 Samuel Padgett 2017-08-07 12:34:54 UTC
Jenkins reports the stage status to us as "Failed" and shows the same icon in the Jenkins user interface. I agree it's a little odd, but I'd rather be consistent with Jenkins.

Comment 3 Samuel Padgett 2017-08-07 12:35:30 UTC
Created attachment 1310035 [details]
Jenkins shows the stage as failed as well