Bug 1480958 (golang-github-BurntSushi-freetype-go)
| Summary: | Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | sensor.wen |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-22 13:30:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1465889 | ||
|
Description
sensor.wen
2017-08-13 08:14:43 UTC
Shouldn't the Release tag include the git hash? There seems to be no released version. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gocode/src/github.com/BurntSushi/freetype-go See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles License tag is incomplete: https://github.com/BurntSushi/freetype-go/blob/master/LICENSE says GPLv2+ or "The FreeType License". This is the same offer that freetype provides. I think it should be "License: GPLv2+ or FTL". + package name is OK + license is acceptable (see above) - license is not specified correctly + latest version + P/R/BR look OK + builds and install OK + fedora-review and rmplint are happy (modulo the issue listed above) rpmlint: golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Package is APPROVED. Please fix the License and Release tags when importing. SPEC: https://raw.githubusercontent.com/FZUG/repo/b37e00151f173afd6f092c29868e2b59a956f609/rpms/deepin_project/golang-github-BurntSushi-freetype-go.spec Thanks I fixed it. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c52b9f5b47 golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c52b9f5b47 |