Bug 1480958 - (golang-github-BurntSushi-freetype-go) Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations
Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go ...
Status: ON_QA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
:
Depends On:
Blocks: DeepinDEPackageReview
  Show dependency treegraph
 
Reported: 2017-08-13 04:14 EDT by sensor.wen
Modified: 2017-12-31 20:45 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Comment 1 Zbigniew Jędrzejewski-Szmek 2017-08-13 20:54:14 EDT
Shouldn't the Release tag include the git hash? There seems to be no released version.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/github.com/BurntSushi/freetype-go
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

License tag is incomplete: https://github.com/BurntSushi/freetype-go/blob/master/LICENSE says GPLv2+ or "The FreeType License". This is the same offer that freetype provides. I think it should be "License: GPLv2+ or FTL".

+ package name is OK
+ license is acceptable (see above)
- license is not specified correctly
+ latest version
+ P/R/BR look OK
+ builds and install OK
+ fedora-review and rmplint are happy (modulo the issue listed above)

rpmlint:
golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Package is APPROVED. Please fix the License and Release tags when importing.
Comment 3 Gwyn Ciesla 2017-08-14 15:52:25 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go
Comment 4 Gwyn Ciesla 2017-08-14 15:52:35 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go
Comment 5 Fedora Update System 2017-10-09 10:57:04 EDT
golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c
Comment 6 Fedora Update System 2017-10-11 02:26:48 EDT
golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c

Note You need to log in before you can comment on or make changes to this bug.