Bug 1481123

Summary: [downstream clone - 4.1.5] [RFE] hosted-engine --set-shared-config should allow modifying fqdn in hosted-engine.conf
Product: Red Hat Enterprise Virtualization Manager Reporter: rhev-integ
Component: ovirt-hosted-engine-setupAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Nikolai Sednev <nsednev>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0.5CC: achareka, lbopf, lsurette, michal.skrivanek, msivak, rbalakri, sbonazzo, sherold, srevivo, stirabos, usurse, ykaul, ylavi
Target Milestone: ovirt-4.1.5Keywords: FutureFeature, TestOnly, Triaged, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
hosted-engine --set-shared-config should allow modifying fqdn in hosted-engine.conf since we already have engine-rename to change it on engine side but the engine was still passing the old value when deploying new hosted-engine hosts.
 Story Points: ---
Clone Of: 1400890 Environment:
Last Closed: 2017-08-25 07:34:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1400890    
Bug Blocks:    

Description rhev-integ 2017-08-14 07:38:25 UTC 
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1400890 +++
======================================================================

3. What is the nature and description of the request?
   When we run the ovirt-engine-rename tool on hosted-engine VM, the configuration of fqdn in the host "/etc/ovirt-hosted-engine/hosted-engine.conf" file. 

# cat /etc/ovirt-hosted-engine/hosted-engine.conf
fqdn=<fqdn>  <<=======  here
vm_disk_id=f27af8d0-b8b8-402b-9114-886bc9a98759
vm_disk_vol_id=3c25f27d-91bf-416d-bc31-a0f11dc245af
vmid=88453282-193c-45d6-8944-ef8c8f8415b4
storage=<host_name>:/RHV4/HE_Data

Steps to Reproduce:
1. Implement hosted einge setup
2. rename hostname of engine with  ovirt-engine-rename tool. 
3. Check cat /etc/ovirt-hosted-engine/hosted-engine.conf


Actual results:
The hostname in hosted engine host to monitor Hosted engine VM heath remains unchanged. 

Expected results:
It should change. 

Additional info:
Workaround is to manually update the file with correct hostname.


4. Why does the customer need this? (List the business requirements here)
   To enable HA for hosted engine VM for monitoring or service. 

5. How would the customer like to achieve this? (List the functional requirements here)
   Change hostname in /etc/ovirt-hosted-engine/hosted-engine.conf file automatically after running ovirt-engine-rename or some other function. 

6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
   Yes

7. Is there already an existing RFE upstream or in Red Hat Bugzilla?
   I filed bug but team asked me to report a feature request. So here it is. 

8. Does the customer have any specific time-line dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
   No

9. Is the sales team involved in this request and do they have any additional input?
   No

10. List any affected packages or components.
    rhevm

11. Would the customer be able to assist in testing this functionality if implemented?
    Yes

(Originally by Ulhas Surse)
Comment 14 rhev-integ 2017-08-14 07:39:37 UTC 
The user should probably use 'hosted-engine --set-shared-config' with the right value for the initial answerfile but currently 'hosted-engine --set-shared-config' let the user just modify notifications related values.

(Originally by Simone Tiraboschi)
Comment 15 rhev-integ 2017-08-14 07:39:42 UTC 
Moving to 4.1.4 not being identified as a blocker for 4.1.3 and depending on bug #1457357 which hasn't been targeted yet.

(Originally by Sandro Bonazzola)
Comment 23 Nikolai Sednev 2017-08-16 16:24:12 UTC 
Works for me, moving to verified.
Please also review the 1400890, which is related to this bug, although it is not blocking the functionality of this bug.

Component's versions:
qemu-kvm-rhev-2.9.0-16.el7_4.3.x86_64
libvirt-client-3.2.0-14.el7_4.2.x86_64
libvirt-lock-sanlock-3.2.0-14.el7_4.2.x86_64
ovirt-hosted-engine-ha-2.1.5-1.el7ev.noarch
ovirt-hosted-engine-setup-2.1.3.6-1.el7ev.noarch
vdsm-4.19.27-1.el7ev.x86_64

Actual results:
# hosted-engine --set-shared-config --help
Usage: /usr/sbin/hosted-engine --set-shared-config key value [--type=<type>]
    Set shared storage configuration.
    Valid types are: broker, he_conf.
    Available only after deployment has completed.
    New values for he_conf (hosted-engine.conf file) will be used by all hosts (re)deployed after the configuration change.
    Currently running hosts will still use the old values.


Available keys are:
he_conf : ['bridge', 'domainType', 'connectionUUID', 'ca_subject', 'conf', 'vm_disk_id', 'gateway', 'console', 'metadata_image_UUID', 'storage', 'lockspace_volume_UUID', 'port', 'sdUUID', 'iqn', 'metadata_volume_UUID', 'vm_disk_vol_id', 'conf_image_UUID', 'ca_cert', 'conf_volume_UUID', 'portal', 'user', 'host_id', 'password', 'lockspace_image_UUID', 'vmid', 'fqdn', 'vdsm_use_ssl', 'mnt_options', 'spUUID']
broker : ['smtp-port', 'destination-emails', 'smtp-server', 'source-email', 'state_transition']

[root@puma18 ~]# hosted-engine --get-shared-config fqdn --type he_conf
fqdn : nsednev-he-4.somewhere.com, type : he_conf
[root@puma18 ~]# hosted-engine --set-shared-config fqdn nsednev-he-4.someone.somewhere.com --type he_conf
[root@puma18 ~]# 
[root@puma18 ~]# cat /etc/ovirt-hosted-engine/hosted-engine.conf | grep fqdn
fqdn=nsednev-he-4.someone.somewhere.com
[root@puma18 ~]# hosted-engine --get-shared-config fqdn --type he_conf
fqdn : nsednev-he-4.someone.somewhere.com, type : he_conf