Bug 1481398

Summary:	libgfapi: memory leak in glfs_h_acl_get
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	libgfapi	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	amukherj, asoman, bturner, bugs, dang, ffilz, jthottan, kkeithle, mbenjamin, ndevos, pgurusid, rcyriac, rgowdapp, rhinduja, rhs-bugs, rtalur, skoduri, srangana, storage-qa-internal, vdas
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8.15	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1481394	Environment:
Last Closed:	2017-08-29 10:19:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1477668
Bug Blocks:	1469558, 1481394

Comment 1 Kaleb KEITHLEY 2017-08-14 20:01:16 UTC

see https://review.gluster.org/#/c/17092/2

already fixed in master, release-3.12, and release-3.11 branches

no BZ was ever filed, no backports to 3.10 and earlier branches

	

    Collapse All Comments
    Expand All Comments
    Add Comment
    Unwrap comments
    Show CC Changes

Comment 2 Worker Ant 2017-08-14 20:29:34 UTC

REVIEW: https://review.gluster.org/18037 (api: memory leak in glfs_h_acl_get(), missing dict unref) posted (#1) for review on release-3.8 by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2017-08-15 10:19:15 UTC

COMMIT: https://review.gluster.org/18037 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 3f26a7ba8d74af3c2f1c149160124e91fac534f8
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Aug 14 16:27:57 2017 -0400

    api: memory leak in glfs_h_acl_get(), missing dict unref
    
    master review https://review.gluster.org/17092 circa April 2017
    Fix already exists in release-3.12 and release-3.11 branches
    
    Hat tip to Shyam (srangana[at]redhat.com) who found the existing
    fix after sitting and debugging it with me for several hours.
    
    Reported-by: Kinglong Mee <mijinlong>
    Change-Id: Ic7169fd05aff7bf46108e8ac7b1f29688a7f2358
    BUG: 1481398
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/18037
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Kinglong Mee <kinglongmee>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Jiffin 2017-08-29 10:19:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.15, please open a new bug report.

glusterfs-3.8.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] blah
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2017-10-03 14:20:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.15, please open a new bug report.

glusterfs-3.8.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-August/000080.html
[2] https://www.gluster.org/pipermail/gluster-users/