Bug 1481597
| Summary: | Review request: python-karborclient | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeremy Liu <liujiong63> |
| Component: | Package Review | Assignee: | Andy Mender <andymenderunix> |
| Status: | CLOSED INSUFFICIENT_DATA | QA Contact: | hguemar |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | amoralej, andymenderunix, karlthered, liujiong63, package-review, ykarel |
| Target Milestone: | --- | Flags: | andymenderunix:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-08-25 19:21:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jeremy Liu
2017-08-15 07:11:24 UTC
Hi Jeremy, Nice one for proposing this package. It would be good to see just some basic information on what karbor is, some kind of inital spec file and srpm. E.g. https://bugzilla.redhat.com/show_bug.cgi?id=1472951 Also I think this needs to block Pike (but probably wont make it for Pike now). Just my initial comments. I've added the link to the RDO Gerrit review for rdoinfo you've already submitted. Thanks, Christopher! Will update needed information soon. Actually, we want this go into Pike, late now? Karbor spec: https://github.com/liujiong63/karbor-rdo-rpm/blob/master/openstack-karbor.spec Description: To protect the Data and Metadata that comprises an OpenStack-deployed Application against loss/damage (e.g. backup, replication) by providing a standard framework of APIs and services that allows vendors to provide plugins through a unified interface (In reply to Jeremy Liu from comment #2) > Thanks, Christopher! Will update needed information soon. Actually, we want > this go into Pike, late now? I don't think so, I just think new packages need to block the next release. I have added that and someone who knows better than me can always change. I don't see why you can't add the package to whichever branches you like once approved but one of the core reviewers can confirm. karborclient spec: https://github.com/liujiong63/karbor-rdo-rpm/blob/master/python-karborclient.spec Description: python-karborclient is a client library for karbor built on the karbor API. It provides a Python API (the karborclient module) and a command-line tool Blocks: 1427510 Blocks: #1427510 Licensecheck result: $ licensecheck -r . ./.coveragerc: *No copyright* UNKNOWN ./.gitreview: *No copyright* UNKNOWN ./.mailmap: *No copyright* UNKNOWN ./.testr.conf: *No copyright* UNKNOWN ./CONTRIBUTING.rst: *No copyright* UNKNOWN ./HACKING.rst: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache (v2.0) ./README.rst: *No copyright* UNKNOWN ./babel.cfg: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache ./setup.py: Apache (v2.0) GENERATED FILE ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./karborclient/__init__.py: *No copyright* Apache (v2.0) ./karborclient/client.py: *No copyright* Apache (v2.0) ./karborclient/i18n.py: *No copyright* Apache (v2.0) ./karborclient/shell.py: *No copyright* Apache (v2.0) ./karborclient/utils.py: *No copyright* Apache (v2.0) ./karborclient/version.py: *No copyright* Apache (v2.0) ./tools/tox_install.sh: *No copyright* UNKNOWN ./doc/source/conf.py: *No copyright* Apache (v2.0) ./doc/source/index.rst: *No copyright* UNKNOWN ./doc/source/readme.rst: *No copyright* UNKNOWN ./karborclient/common/base.py: *No copyright* Apache (v2.0) ./karborclient/common/http.py: Apache (v2.0) ./karborclient/common/utils.py: *No copyright* Apache (v2.0) ./karborclient/osc/plugin.py: *No copyright* Apache (v2.0) ./karborclient/v1/checkpoints.py: *No copyright* Apache (v2.0) ./karborclient/v1/client.py: Apache (v2.0) ./karborclient/v1/operation_logs.py: *No copyright* Apache (v2.0) ./karborclient/v1/plans.py: *No copyright* Apache (v2.0) ./karborclient/v1/protectables.py: *No copyright* Apache (v2.0) ./karborclient/v1/providers.py: *No copyright* Apache (v2.0) ./karborclient/v1/restores.py: *No copyright* Apache (v2.0) ./karborclient/v1/scheduled_operations.py: *No copyright* Apache (v2.0) ./karborclient/v1/shell.py: *No copyright* Apache (v2.0) ./karborclient/v1/triggers.py: *No copyright* Apache (v2.0) ./doc/source/contributor/index.rst: *No copyright* UNKNOWN ./doc/source/install/index.rst: *No copyright* UNKNOWN ./doc/source/specs/index.rst: *No copyright* UNKNOWN ./doc/source/specs/karbor-support-in-python-openstackclient.rst: *No copyright* CC by (v3.0) ./doc/source/user/index.rst: *No copyright* UNKNOWN ./karborclient/common/apiclient/auth.py: Apache (v2.0) ./karborclient/common/apiclient/base.py: Apache (v2.0) ./karborclient/common/apiclient/client.py: Apache (v2.0) ./karborclient/common/apiclient/exceptions.py: Apache (v2.0) ./karborclient/common/apiclient/fake_client.py: Apache (v2.0) ./karborclient/osc/v1/checkpoints.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/operation_logs.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/plans.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/protectables.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/providers.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/restores.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/scheduled_operations.py: *No copyright* Apache (v2.0) ./karborclient/osc/v1/triggers.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/base.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/fakes.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/test_http.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/test_karborclient.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/test_shell.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/fakes.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_checkpoints.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_operation_logs.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_plans.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_protectables.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_providers.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_restores.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_scheduled_operations.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/v1/test_triggers.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/__init__.py: *No copyright* UNKNOWN ./karborclient/tests/unit/osc/v1/fakes.py: Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_checkpoints.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_operation_logs.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_plans.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_protectables.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_providers.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_restores.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_scheduledoperations.py: *No copyright* Apache (v2.0) ./karborclient/tests/unit/osc/v1/test_triggers.py: *No copyright* Apache (v2.0) License is valid Apache Software License v2.0 Note that file /doc/source/specs/karbor-support-in-python-openstackclient.rst has license header CC by (v3.0). This file is not included in the package so i'd say we don't need to follow multiple licenses recomendations in https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios but i'll check what documentation are we including. Are ok with moving it to Fedora? FE-NEEDSPONSOR The review got abandoned https://review.rdoproject.org/r/#/c/8675/ after three years of inactivity, if some one want can reopen it, for now i removed RDO-PIKE tracker as pike released long ago Picking it up to review it or close it. Alfredo, are you still interested in this package? It seems requestor has no more interest, so, i guess we can close it. Closing due to inactivity. |