Packaging for Senlin and its client URL: https://github.com/snecklifter/senlin-rdo-rpm Senlin client spec: https://raw.githubusercontent.com/snecklifter/senlin-rdo-rpm/master/python-senlinclient.spec Description: Python client for Senlin REST API. Includes python library for Senlin API, Command Line Interface (CLI) library and openstackclient plugin.
Package review should block the tracking ticket RDO-PIKE (or RDO-<NEXTRELEASE>)
This is currently blocked waiting for switch to docstheme from oslosphinx on: https://review.openstack.org/#/c/480094/
docstheme patch has now been merged so continuing...
(In reply to Haïkel Guémar from comment #1) > Package review should block the tracking ticket RDO-PIKE (or > RDO-<NEXTRELEASE>) Thanks Haikel, would you mind doing the license check please?
distgit has merged, could I get a license and package review on this please?
official review using spec in approved spec version in https://review.rdoproject.org/r/#/c/7902/ SRPM: https://logs.rdoproject.org/02/7902/8/gate/DLRN-rpmbuild/Z240ba686416f4e49b69fb4866af44a17/centos/current/python-senlinclient-1.4.1-0.20170808085453.65dcd7e.el7.centos.src.rpm Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 51 files have unknown license. Detailed output of licensecheck in /tmp/python-senlinclient/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-senlinclient , python2-senlinclient-tests-unit , python- senlinclient-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 1.4.1.dev3 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-senlinclient-1.4.1-0.20170808085453.65dcd7e.el7.centos.noarch.rpm python2-senlinclient-tests-unit-1.4.1-0.20170808085453.65dcd7e.el7.centos.noarch.rpm python-senlinclient-doc-1.4.1-0.20170808085453.65dcd7e.el7.centos.noarch.rpm python-senlinclient-1.4.1-0.20170808085453.65dcd7e.el7.centos.src.rpm python2-senlinclient.noarch: E: no-changelogname-tag python2-senlinclient.noarch: W: no-manual-page-for-binary senlin-2.7 python2-senlinclient.noarch: W: no-manual-page-for-binary senlin-2 python2-senlinclient-tests-unit.noarch: W: spelling-error Summary(en_US) senlin -> linens python2-senlinclient-tests-unit.noarch: W: spelling-error %description -l en_US senlin -> linens python2-senlinclient-tests-unit.noarch: E: no-changelogname-tag python2-senlinclient-tests-unit.noarch: W: no-documentation python-senlinclient-doc.noarch: W: spelling-error Summary(en_US) senlin -> linens python-senlinclient-doc.noarch: W: spelling-error %description -l en_US senlin -> linens python-senlinclient-doc.noarch: E: no-changelogname-tag python-senlinclient-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-senlinclient-doc-1.4.1/html/objects.inv python-senlinclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-senlinclient-doc-1.4.1/html/objects.inv python-senlinclient.src: W: spelling-error %description -l en_US senlin -> linens python-senlinclient.src: E: no-changelogname-tag python-senlinclient.src: W: invalid-url Source0: python-senlinclient-1.4.1.dev3-0.20170808085453.65dcd7e.tar.gz 4 packages and 0 specfiles checked; 4 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- python2-senlinclient-tests-unit.noarch: E: no-changelogname-tag python2-senlinclient-tests-unit.noarch: W: no-documentation python-senlinclient-doc.noarch: E: no-changelogname-tag python2-senlinclient.noarch: E: no-changelogname-tag python2-senlinclient.noarch: W: no-manual-page-for-binary senlin-2.7 python2-senlinclient.noarch: W: no-manual-page-for-binary senlin-2 3 packages and 0 specfiles checked; 3 errors, 3 warnings. Requires -------- python2-senlinclient-tests-unit (rpmlib, GLIBC filtered): /bin/bash python(abi) python-fixtures python-mock python-oslotest python-pep8 python-requests-mock python-testrepository python-testscenarios python-testtools python2-senlinclient python-senlinclient-doc (rpmlib, GLIBC filtered): python2-senlinclient (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-babel python-heatclient python-keystoneauth1 python-openstacksdk python-osc-lib python-oslo-i18n python-oslo-serialization python-oslo-utils python-pbr python-prettytable python-requests python-six Provides -------- python2-senlinclient-tests-unit: python2-senlinclient-tests-unit python-senlinclient-doc: python-senlinclient-doc python2-senlinclient: python-senlinclient python2-senlinclient Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m dlrn-master -rn python-senlinclient-1.4.1-0.20170808085453.65dcd7e.el7.centos.src.rpm Buildroot used: dlrn-centos-master-x86_64-1 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Some comments about reported issues: - about license.png not marked as %license, that file is only a logo included in the html documentation, not license text. - about rpmlint error, no-changelogname-tag, this spec is intended to be used by DLRN which doesn't use changelog. Package is APPROVED