Bug 1481830

Summary: [RFE] [RHCS 2.y] osd: osd_scrub_during_recovery only considers primary, not replicas
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Vikhyat Umrao <vumrao>
Component: RADOSAssignee: David Zafman <dzafman>
Status: CLOSED ERRATA QA Contact: ceph-qe-bugs <ceph-qe-bugs>
Severity: medium Docs Contact: Bara Ancincova <bancinco>
Priority: medium    
Version: 2.3CC: anharris, ceph-eng-bugs, dzafman, gmeno, icolle, kchai, kdreyer, pamadio, tserlin, vakulkar, vumrao
Target Milestone: rcKeywords: FutureFeature
Target Release: 2.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: RHEL: ceph-10.2.7-48.el7cp Ubuntu: ceph_10.2.7-48redhat1 Doc Type: Enhancement
Doc Text:
.Scrubbing is blocked for any PG if the primary or any replica OSDs are recovering The `osd_scrub_during_recovery` parameter now defaults to `false`, so that when an OSD is recovering, the scrubbing process is not initialized on it. Previously, `osd_scrub_during_recovery` was set to `true` by default allowing scrubbing and recovery to run simultaneously. In addition, in previous releases if the user set `osd_scrub_during_recovery` to `false`, only the primary OSD was checked for recovery activity.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-17 18:12:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1473436, 1479701    

Description Vikhyat Umrao 2017-08-15 20:16:34 UTC
Description of problem:
[RFE] [RHCS 2.y] osd: osd_scrub_during_recovery only considers primary, not replicas

http://tracker.ceph.com/issues/18206



Version-Release number of selected component (if applicable):
Red Hat Ceph Storage 2.3

Comment 2 Vikhyat Umrao 2017-08-24 17:51:59 UTC
Jewel backport tracker:
http://tracker.ceph.com/issues/21117

Comment 4 Vikhyat Umrao 2017-09-25 17:03:12 UTC
jewel backport: https://github.com/ceph/ceph/pull/17815

Comment 5 Christina Meno 2017-10-02 20:52:16 UTC
We're going to need this applied downstream Vikhyat. Would you please let me know when that will be ready?

Comment 6 Vikhyat Umrao 2017-10-02 21:25:48 UTC
(In reply to Gregory Meno from comment #5)
> We're going to need this applied downstream Vikhyat. Would you please let me
> know when that will be ready?

Thanks Gregory. I just checked upstream PR - https://github.com/ceph/ceph/pull/17815 It is under Kefu testing branch and I think as soon as upstream testing will complete. David should be able to take it downstream.

I am changing the needinfo to David.

Comment 7 Ian Colle 2017-10-04 15:48:56 UTC
Kefu,

When do you think https://github.com/ceph/ceph/labels/wip-kefu-testing will be merged?

Comment 13 David Zafman 2017-10-11 20:40:04 UTC
Ken: To test this change you need to include https://bugzilla.redhat.com/show_bug.cgi?id=1482749 or set osd_scrub_during_recovery false.

Comment 21 errata-xmlrpc 2017-10-17 18:12:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2903

Comment 24 Vikhyat Umrao 2018-10-05 20:11:50 UTC
*** Bug 1636475 has been marked as a duplicate of this bug. ***