Bug 1483351

Summary:	Container Review Request: s2i-core - Minimal base platform for other s2i images
Product:	[Fedora] Fedora Container Images	Reporter:	Honza Horak <hhorak>
Component:	Container Review	Assignee:	Marek Skalický <mskalick>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	container-review, hhorak, mskalick
Target Milestone:	---	Flags:	mskalick: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-26 10:42:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Honza Horak 2017-08-20 20:26:00 UTC

Dockerfile URL: https://hhorak.fedorapeople.org/s2i-core-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/s2i-core-docker/

Description: The s2i-core image provides any images layered on top of it with all the tools needed to use source-to-image functionality while keeping the image size as small as possible.

Fedora Account System Username: hhorak

Comment 1 Marek Skalický 2017-08-21 07:42:52 UTC

Hi,
few comments:

- run or usage label is missing (https://fedoraproject.org/wiki/Container:Guidelines#LABELS)
- help.1 or README.md is missing (https://fedoraproject.org/wiki/Container:Guidelines#Help_File)

Otherwise it looks good, thanks.

Marek

Comment 2 Honza Horak 2017-08-21 08:27:25 UTC

(In reply to Marek Skalický from comment #1)
> - run or usage label is missing
> (https://fedoraproject.org/wiki/Container:Guidelines#LABELS)
> - help.1 or README.md is missing
> (https://fedoraproject.org/wiki/Container:Guidelines#Help_File)

This is weird, README.md is there, it is however not listed when listing the directory.. Anyway, I copied it to help.1, so both issues are fixed:
https://hhorak.fedorapeople.org/s2i-core-docker/Dockerfile
https://hhorak.fedorapeople.org/s2i-core-docker/help.1

Thanks for quick review.

Comment 3 Marek Skalický 2017-08-21 09:19:28 UTC

Thanks, everything seems good now.

Comment 4 Gwyn Ciesla 2017-09-04 18:26:46 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/s2i-core