Dockerfile URL: https://hhorak.fedorapeople.org/s2i-core-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/s2i-core-docker/ Description: The s2i-core image provides any images layered on top of it with all the tools needed to use source-to-image functionality while keeping the image size as small as possible. Fedora Account System Username: hhorak
Hi, few comments: - run or usage label is missing (https://fedoraproject.org/wiki/Container:Guidelines#LABELS) - help.1 or README.md is missing (https://fedoraproject.org/wiki/Container:Guidelines#Help_File) Otherwise it looks good, thanks. Marek
(In reply to Marek Skalický from comment #1) > - run or usage label is missing > (https://fedoraproject.org/wiki/Container:Guidelines#LABELS) > - help.1 or README.md is missing > (https://fedoraproject.org/wiki/Container:Guidelines#Help_File) This is weird, README.md is there, it is however not listed when listing the directory.. Anyway, I copied it to help.1, so both issues are fixed: https://hhorak.fedorapeople.org/s2i-core-docker/Dockerfile https://hhorak.fedorapeople.org/s2i-core-docker/help.1 Thanks for quick review.
Thanks, everything seems good now.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/container/s2i-core