Bug 1483521

Summary:	Trim whitespaces in all the user provided text in the cockpit UI
Product:	[oVirt] cockpit-ovirt	Reporter:	SATHEESARAN <sasundar>
Component:	Gdeploy	Assignee:	Gobinda Das <godas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.10.7-0.0.23	CC:	bugs, godas, knarra, rbarry, sabose
Target Milestone:	ovirt-4.1.6	Flags:	rule-engine: ovirt-4.1? sasundar: planning_ack? rule-engine: devel_ack+ sasundar: testing_ack+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.10.8-2.0.ovirt41.el7ev	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1455010	Environment:
Last Closed:	2017-09-19 10:02:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description SATHEESARAN 2017-08-21 10:45:13 UTC

Description
------------
The issue of **not** trimming whitespaces was already fixed for volume and brick properties with the bug 1455010. 

This bug is to request for the same fix on all the user input fields - hostnames, repository names ( comma separated ), package names ( comma separated ).

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHVH 4.1
cockpit-ovirt-dashboard-0.10.7-0.0.23

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. While specifying the volume name and brick's mount point, leave a space after  specifying the hostname ( or add a whitespace next to package name or repo-name )

Actual results:
---------------
The space is passed on the gdeploy config file.

Expected results:
-----------------
All the text that obtains the input from user should filter out the whitespaces

Comment 1 Red Hat Bugzilla Rules Engine 2017-08-21 10:45:19 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 SATHEESARAN 2017-08-21 10:50:05 UTC

Please make sure that all the user input fields in cockpit has the whitespaces removed.


Fields like repositories & package names can obtain the following values as input:

package1, package2 ----- should be corrected as ---> package1,package2
repo1, repo2       ----- should be corrected as ---> repo1,repo2

Also the leading spaces also should be trimmed

Comment 3 SATHEESARAN 2017-09-14 11:20:16 UTC

Tested with cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch

Trim spaces purposefully introduced with hostnames, brick names, and also with package names, repo names are filtered out.