Bug 1483931

Summary:	Verify_health_checks.yml is not in upgrade_nodes.yml and upgrade_control_plane.yml
Product:	OpenShift Container Platform	Reporter:	Anping Li <anli>
Component:	Cluster Version Operator	Assignee:	Juan Vallejo <jvallejo>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	aos-bugs, bleanhar, jokerman, lmeyer, mmccomas, rcarvalh
Target Milestone:	---
Target Release:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-28 22:07:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Anping Li 2017-08-22 09:49:32 UTC

Description of problem:

The  Disk and memory check is not in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml&upgrade_control_plane.yml

Version-Release number of the following components:
openshift-ansible: master

How reproducible:
always

Steps to Reproduce:
1. Check code in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_control_plane.yml
2. Check code in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml


Actual results:
verify_health_checks.yml is not in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml&upgrade_control_plane.yml

Expected results:
upgrade_nodes.yml&upgrade_control_plane.yml should include verify_health_checks.yml  to enable disk/memory check feature


Additional info:

Comment 1 Rodolfo Carvalho 2017-08-25 07:36:53 UTC

Juan, could you help triage this please? Is it something that is intentionally missing or a bug?

Comment 2 Juan Vallejo 2017-08-25 15:37:50 UTC

From what I can tell, both the memory availability and disk space checks are included as part of the 3.7 upgrade path under the "verify_health_checks.yml" playbook: https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade.yml#L74

Comment 3 Anping Li 2017-09-11 06:51:17 UTC

@Juan, there are three entry playbooks for upgrade - upgrade.yml, upgrade_control_plane.yml and upgrade_nodes.yml. verify_health_checks.yml also need to be added in [2] and [3].  For more detail, refer to [1]


[1] https://docs.openshift.com/container-platform/3.6/install_config/upgrading/automated_upgrades.html#upgrading-control-plane-nodes-separate-phases

[2]https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_control_plane.yml

[3]https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml

Comment 4 Juan Vallejo 2017-09-11 15:51:18 UTC

@anli thanks, opened PR to address this here: https://github.com/openshift/openshift-ansible/pull/5357

Comment 5 Luke Meyer 2017-09-13 16:52:28 UTC

This is really more an enhancement than a bug; we will plan to merge it next week during the normal merge window.

Comment 6 Anping Li 2017-11-02 03:10:30 UTC

Verified and pass on openshift-ansible-3.7.0-0.189.0.git.0.d497c5e.el7.noarch

Comment 9 errata-xmlrpc 2017-11-28 22:07:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188