Bug 1483931 - Verify_health_checks.yml is not in upgrade_nodes.yml and upgrade_control_plane.yml
Summary: Verify_health_checks.yml is not in upgrade_nodes.yml and upgrade_control_plan...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 3.7.0
Assignee: Juan Vallejo
QA Contact: Anping Li
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-22 09:49 UTC by Anping Li
Modified: 2017-11-28 22:07 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-28 22:07:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:3188 0 normal SHIPPED_LIVE Moderate: Red Hat OpenShift Container Platform 3.7 security, bug, and enhancement update 2017-11-29 02:34:54 UTC

Description Anping Li 2017-08-22 09:49:32 UTC
Description of problem:

The  Disk and memory check is not in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml&upgrade_control_plane.yml

Version-Release number of the following components:
openshift-ansible: master

How reproducible:
always

Steps to Reproduce:
1. Check code in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_control_plane.yml
2. Check code in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml


Actual results:
verify_health_checks.yml is not in openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade_nodes.yml&upgrade_control_plane.yml

Expected results:
upgrade_nodes.yml&upgrade_control_plane.yml should include verify_health_checks.yml  to enable disk/memory check feature


Additional info:

Comment 1 Rodolfo Carvalho 2017-08-25 07:36:53 UTC
Juan, could you help triage this please? Is it something that is intentionally missing or a bug?

Comment 2 Juan Vallejo 2017-08-25 15:37:50 UTC
From what I can tell, both the memory availability and disk space checks are included as part of the 3.7 upgrade path under the "verify_health_checks.yml" playbook: https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/v3_7/upgrade.yml#L74

Comment 4 Juan Vallejo 2017-09-11 15:51:18 UTC
@anli thanks, opened PR to address this here: https://github.com/openshift/openshift-ansible/pull/5357

Comment 5 Luke Meyer 2017-09-13 16:52:28 UTC
This is really more an enhancement than a bug; we will plan to merge it next week during the normal merge window.

Comment 6 Anping Li 2017-11-02 03:10:30 UTC
Verified and pass on openshift-ansible-3.7.0-0.189.0.git.0.d497c5e.el7.noarch

Comment 9 errata-xmlrpc 2017-11-28 22:07:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188


Note You need to log in before you can comment on or make changes to this bug.