Bug 1484409

Summary:	Review Request: autotools - module for GNU toolchain (autoconf, automake, libtool)
Product:	[Fedora] Fedora Modules	Reporter:	Tomas Tomecek <ttomecek>
Component:	Module Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	karsten, ppisar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-01 13:03:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Tomecek 2017-08-23 13:34:37 UTC

Modulemd URL: https://ttomecek.fedorapeople.org/autotools.yaml
Description: 
        This module is composed of well-known GNU tools, such as autoconf,
        automake and libtool.

Fedora Account System Username: ttomecek

Comment 1 Igor Gnatenko 2017-08-23 14:44:11 UTC

why do you put debugsource and debuginfo into API? ;)

Comment 2 Igor Gnatenko 2017-08-23 14:45:08 UTC

Also I think libtool package should be included in default profile.

Comment 3 Tomas Tomecek 2017-08-23 16:03:00 UTC

(In reply to Igor Gnatenko from comment #1)
> why do you put debugsource and debuginfo into API? ;)

Is there a guideline for it? I assume that these packages are meant to be supported.


Yeah, I can include libtool. Wasn't really sure about that.

Same URL, default profile now includes libtool as well:
Modulemd URL: https://ttomecek.fedorapeople.org/autotools.yaml

Comment 4 Petr Pisar 2017-08-29 08:29:14 UTC

I also do not list debugging subpackages in the API because filter skip them automatically. I expect this symmetry. If this is not true, the modulemd specification should be explicit about this.

Comment 5 Petr Pisar 2017-08-30 15:09:51 UTC

I filed a review for help2man (bug #1486812). That will be used for autoconf module. Autoconf is possible to build without funny dependencies like on Emacs. The autotools really should be built from bootstrap.

Comment 6 Petr Pisar 2017-08-31 14:30:57 UTC

I have review for autoconf (bug #1487153) and automake (bug #1487275). Both are built from platform.

If you really think they belong into one module, I can squash them. But I'm not fond of putting libtool there because it's already provided by platform.

Comment 7 Karsten Hopp 2017-08-31 15:33:40 UTC

I think that autoconf should be included in this module, I'm unsure where help2man belongs. Having 2 minimal modules with just a single package in each (autoconf and help2man) doesn't look like a good way to do modules to me.

Comment 8 Petr Pisar 2017-09-01 06:31:01 UTC

Here (bug #1487508) is a autotools module with Autoconf and Automake in one module without dependency on help2man module.

Comment 9 Tomas Tomecek 2017-09-01 13:03:29 UTC

Oh, I missed the fact that libtool is included in platform.

Closing this review in favor of Petr's submission.

Comment 10 Petr Pisar 2017-10-06 12:25:40 UTC

I reviewed platform module with contyk and we agreed on moving libtool binary package from platform to autotools. libtool-ltdl{,-devel} binary packages will remain in platform.