Bug 1487110

Summary:	Role configuration of nodes doesn't close or save properly
Product:	Red Hat OpenStack	Reporter:	Dima <dbrusilo>
Component:	openstack-tripleo-ui	Assignee:	Jiri Tomasek <jtomasek>
Status:	CLOSED ERRATA	QA Contact:	Udi Kalifon <ukalifon>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	12.0 (Pike)	CC:	beth.white, jjoyce, jschluet, jtomasek, slinaber, tvignaud
Target Milestone:	Upstream M3	Keywords:	Regression, Triaged
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-ui-8.3.1-0.20180303225336.57e3d96.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-27 13:34:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dima 2017-08-31 09:28:14 UTC

Description of problem:
When attempting to edit role parameters, the windows will not close after saving changes (missing "save and close" button). Also, when switching tabs, changes will not save unless "save changes" is pressed.  

Version-Release number of selected component (if applicable):


How reproducible:
When editing role parameters

Steps to Reproduce:
1. Log in to director ui
2. From  Deployment plan page edit role configuration by clicking on a "pen" icon on the right top corner of the role
3. Change one of the parameters
4. Switch to a different tab and back
5. Click on "save changes"

Actual results:
The change that was made before switching to a different tab was not saved and clicking on "save changes" is needed before switching to another tab which is counter-intuitive. After clicking on "save changes" the window will not close.

Expected results:
Configuration was successfully saved. After clicking "save changes" deployment plan page is shown. Changes on one tab should be saved when switching to another without the need to click "save changes"

Comment 4 Jiri Tomasek 2018-02-06 10:40:22 UTC

This bug is partially fixed by https://review.openstack.org/#/c/541237/ but in general it is going to be fixed once role detail form gets converted to using redux-form

Comment 6 Jiri Tomasek 2018-02-14 08:36:15 UTC

I have added references to 2 additional gerrit patches which convert RoleDetail dialog to redux-form. These completely fix all the issues reported here. These patches are supposed to land in Queens RC1, so in time for OSP13

Comment 9 Udi Kalifon 2018-04-04 11:18:25 UTC

Verified: openstack-tripleo-ui-8.3.1-2.el7ost.noarch

Comment 11 errata-xmlrpc 2018-06-27 13:34:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086