Bug 1487419

Summary:	Review Request: wsprx - Weak Signal Propagation Reporter
Product:	[Fedora] Fedora	Reporter:	Jaroslav Škarvada <jskarvad>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, fedora, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-01 21:59:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jaroslav Škarvada 2017-08-31 21:06:34 UTC

Spec URL: https://jskarvad.fedorapeople.org/wsprx/wsprx.spec
SRPM URL: https://jskarvad.fedorapeople.org/wsprx/wsprx-0.9-1.20170831svn8046.fc25.src.rpm
Description: WSPR implements a protocol designed for probing potential radio signal propagation paths with low-power transmissions. Normal transmissions carry a station's callsign, Maidenhead grid locator, and transmitter power in dBm. This program can decode signals with S/N as low as -28 dB in a 2500 Hz bandwidth. Stations with internet access can automatically upload their reception reports to a central database called WSPRnet, which includes a mapping facility.
Fedora Account System Username: jskarvad

Comment 1 Artur Frenszek-Iwicki 2017-08-31 22:07:24 UTC

>Group:		Applications/Engineering
The "Group" tag should not be used. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>%{_datadir}/icons/hicolor/32x32/apps/wsprx.png
This directory has an unknown owner. You should add "Requires: hicolor-icon-theme".

Comment 2 Robert-André Mauchin 🐧 2017-09-01 15:57:10 UTC

Hello,


Additionally:

 - You can replace make %{?_smp_mflags} install DESTDIR=%{buildroot} with %make_install
 - make %{?_smp_mflags} → %make_build

 - Why do you make a -doc subpackage for a single file? Just include it in the %doc directive:

%files
%doc WSPR-X_Users_Guide.pdf

 - Why do you want to convert the docx to a PDF? And why do you pull Libreoffice Writer (which is a huge dependency) to just do that?

If you feel necessary to join the help in PDF, I think it would be better to add it as Source1 with a comment on how you converted it. (for that I suggest you to also look at pandoc, a command line tool to convert to and from multiple format).

Comment 3 Jaroslav Škarvada 2017-09-01 16:28:09 UTC

(In reply to Robert-André Mauchin from comment #2)
>  - Why do you make a -doc subpackage for a single file? Just include it in
> the %doc directive:
> 
> %files
> %doc WSPR-X_Users_Guide.pdf
> 
That's intended, not everybody needs the guide.

>  - Why do you want to convert the docx to a PDF?
Because docx is um, non optimal format. Not everybody has reader for it. And btw upstream also converts to PDF and ships PDF in binary package.

> And why do you pull
> Libreoffice Writer (which is a huge dependency) to just do that?
>
Not an issue, build time dep.
 
> If you feel necessary to join the help in PDF, I think it would be better to
> add it as Source1 with a comment on how you converted it. (for that I
It's better to automate and convert it in build time instead of ad-hoc manual hacks.

> suggest you to also look at pandoc, a command line tool to convert to and
> from multiple format).
Libreoffice do a much better job.

Comment 4 Jaroslav Škarvada 2017-09-01 16:31:21 UTC

Btw at the moment I am trying to package WSJT-X, which is a bit tricky. According to upstream WSJT-X superseded WSPR-X, so if I successfully package it, I will probably drop this request - if not, I will go with WSPR-X instead (it can still do the job).

Comment 5 Jaroslav Škarvada 2017-09-01 21:59:54 UTC

Upstream statement regarding WSPR-X and WSJT-X:
"I do not recommend packaging WSPR-X for any platform or distribution.  WSPR-X is obsolete, and no longer supported. Its functions are limited, and anyway now much better served by WSJT-X."

WSJT-X review request is in bug 1487776.

So closing this.