Spec URL: https://jskarvad.fedorapeople.org/wsprx/wsprx.spec SRPM URL: https://jskarvad.fedorapeople.org/wsprx/wsprx-0.9-1.20170831svn8046.fc25.src.rpm Description: WSPR implements a protocol designed for probing potential radio signal propagation paths with low-power transmissions. Normal transmissions carry a station's callsign, Maidenhead grid locator, and transmitter power in dBm. This program can decode signals with S/N as low as -28 dB in a 2500 Hz bandwidth. Stations with internet access can automatically upload their reception reports to a central database called WSPRnet, which includes a mapping facility. Fedora Account System Username: jskarvad
>Group: Applications/Engineering The "Group" tag should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >%{_datadir}/icons/hicolor/32x32/apps/wsprx.png This directory has an unknown owner. You should add "Requires: hicolor-icon-theme".
Hello, Additionally: - You can replace make %{?_smp_mflags} install DESTDIR=%{buildroot} with %make_install - make %{?_smp_mflags} → %make_build - Why do you make a -doc subpackage for a single file? Just include it in the %doc directive: %files %doc WSPR-X_Users_Guide.pdf - Why do you want to convert the docx to a PDF? And why do you pull Libreoffice Writer (which is a huge dependency) to just do that? If you feel necessary to join the help in PDF, I think it would be better to add it as Source1 with a comment on how you converted it. (for that I suggest you to also look at pandoc, a command line tool to convert to and from multiple format).
(In reply to Robert-André Mauchin from comment #2) > - Why do you make a -doc subpackage for a single file? Just include it in > the %doc directive: > > %files > %doc WSPR-X_Users_Guide.pdf > That's intended, not everybody needs the guide. > - Why do you want to convert the docx to a PDF? Because docx is um, non optimal format. Not everybody has reader for it. And btw upstream also converts to PDF and ships PDF in binary package. > And why do you pull > Libreoffice Writer (which is a huge dependency) to just do that? > Not an issue, build time dep. > If you feel necessary to join the help in PDF, I think it would be better to > add it as Source1 with a comment on how you converted it. (for that I It's better to automate and convert it in build time instead of ad-hoc manual hacks. > suggest you to also look at pandoc, a command line tool to convert to and > from multiple format). Libreoffice do a much better job.
Btw at the moment I am trying to package WSJT-X, which is a bit tricky. According to upstream WSJT-X superseded WSPR-X, so if I successfully package it, I will probably drop this request - if not, I will go with WSPR-X instead (it can still do the job).
Upstream statement regarding WSPR-X and WSJT-X: "I do not recommend packaging WSPR-X for any platform or distribution. WSPR-X is obsolete, and no longer supported. Its functions are limited, and anyway now much better served by WSJT-X." WSJT-X review request is in bug 1487776. So closing this.