Bug 1488171

Summary:	Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Alien-PCRE2-0.013000-1.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-05 07:06:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2017-09-04 14:27:31 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2-0.013000-1.fc28.src.rpm
Description:
This package can be used by other Perl modules that require PCRE2 library, the
new Perl Compatible Regular Expression engine.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-09-04 15:28:47 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c
      1 pcre2-devel(x86-64)
      1 perl(Alien::Base)
      1 perl(Alien::PCRE2)
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Alien::PCRE2) = 0.013000
      1 perl-Alien-PCRE2 = 0.013000-1.fc28
      1 perl(Alien::PCRE2::Install::Files)
      1 perl-Alien-PCRE2(x86-64) = 0.013000-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Alien-PCRE2*
perl-Alien-PCRE2.x86_64: E: no-binary
perl-Alien-PCRE2.x86_64: W: only-non-binary-in-usr-lib
2 packages and 1 specfiles checked; 1 errors, 1 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-09-04 18:40:19 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-PCRE2

Comment 3 Petr Pisar 2017-09-05 07:06:15 UTC

Thank you for the review and the repository.