Bug 1488171 - Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
Summary: Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-04 14:27 UTC by Petr Pisar
Modified: 2017-09-05 07:06 UTC (History)
2 users (show)

Fixed In Version: perl-Alien-PCRE2-0.013000-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-05 07:06:15 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-09-04 14:27:31 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2-0.013000-1.fc28.src.rpm
Description:
This package can be used by other Perl modules that require PCRE2 library, the
new Perl Compatible Regular Expression engine.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-09-04 15:28:47 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c
      1 pcre2-devel(x86-64)
      1 perl(Alien::Base)
      1 perl(Alien::PCRE2)
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c
      1 perl(Alien::PCRE2) = 0.013000
      1 perl-Alien-PCRE2 = 0.013000-1.fc28
      1 perl(Alien::PCRE2::Install::Files)
      1 perl-Alien-PCRE2(x86-64) = 0.013000-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Alien-PCRE2*
perl-Alien-PCRE2.x86_64: E: no-binary
perl-Alien-PCRE2.x86_64: W: only-non-binary-in-usr-lib
2 packages and 1 specfiles checked; 1 errors, 1 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-09-04 18:40:19 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-PCRE2

Comment 3 Petr Pisar 2017-09-05 07:06:15 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.