Bug 1488359

Summary:	[3.3] "when statements should not include jinja2 templating delimiters" warning is shown when running installer with ansible-2.3.1.0-3.el7.noarch
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Installer	Assignee:	Russell Teague <rteague>
Status:	CLOSED ERRATA	QA Contact:	Johnny Liu <jialiu>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.3.0	CC:	aos-bugs, jokerman, mmccomas, rteague
Target Milestone:	---
Target Release:	3.3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	With Ansible 2.3 warnings are issued when using Jinja delimiters in 'when' conditions. The delimiters have been removed from the code base to avoid these warnings.	Story Points:	---
Clone Of:	1480129	Environment:
Last Closed:	2017-10-17 11:45:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1480129, 1488360, 1488361, 1488363
Bug Blocks:

Description Johnny Liu 2017-09-05 08:20:45 UTC

+++ This bug was initially created as a clone of Bug #1480129 +++

Description of problem:
When running 3.2 installer with ansible 2.3, a lot of warning is shown up, though it is harmless.


PLAY [Populate config host groups] *********************************************

TASK [fail] ********************************************************************
Thursday 10 August 2017  02:13:09 +0000 (0:00:00.047)       0:00:00.316 ******* 
 [WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: {{ g_etcd_hosts is not defined }}

Pls search "when statements should not include jinja2 templating delimiters" keyword in the attached installation log to find more.


Version-Release number of the following components:
ansible-2.3.1.0-3.el7.noarch
openshift-ansible-3.2.63-1.git.0.a21de5e.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
a lot of warning is shown after switch ansible version from 2.2 to 2.3

Expected results:
No more warning.

Additional info:
Please attach logs from ansible-playbook with the -vvv flag


Description of problem:

Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

--- Additional comment from Johnny Liu on 2017-08-10 05:13 EDT ---



--- Additional comment from Johnny Liu on 2017-08-10 05:59:16 EDT ---

Other version of installer (3.3 ~ 3.6) also has such issues, but the occurrence is less than 3.2.

--- Additional comment from Russell Teague on 2017-08-24 20:21:25 EDT ---

Proposed: https://github.com/openshift/openshift-ansible/pull/5207

--- Additional comment from Russell Teague on 2017-08-29 13:12:14 EDT ---

Merged: https://github.com/openshift/openshift-ansible/pull/5207

Comment 1 Russell Teague 2017-09-05 12:36:04 UTC

Merged: https://github.com/openshift/openshift-ansible/pull/5221

Comment 3 Johnny Liu 2017-09-07 07:32:59 UTC

Waiting for newer errata puddle to include the fix.

Comment 4 Johnny Liu 2017-09-15 01:40:47 UTC

No openshift-ansible build is attached to errata, no errata puddle, move it to "MODIFIED"

Comment 6 Johnny Liu 2017-09-19 03:32:58 UTC

Retest this bug with openshift-ansible-3.3.122-1.git.0.de5e8f9.el7, and FAIL.

Still have some warning:
<--snip-->
TASK [openshift_serviceaccounts : Grant the user access to the appropriate scc] ***
Tuesday 19 September 2017  03:08:51 +0000 (0:00:00.421)       0:07:24.940 ***** 
 [WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: 'system:serviceaccount:{{
openshift_serviceaccounts_namespace }}:{{ item.0 }}' not in {{ (item.1.stdout |
from_yaml).users | default([]) }}

Comment 7 Russell Teague 2017-09-19 12:16:35 UTC

Proposed: https://github.com/openshift/openshift-ansible/pull/5457

Comment 9 Johnny Liu 2017-09-28 05:33:42 UTC

Verified this bug with openshift-ansible-3.3.125-1.git.0.60aef4f.el7.noarch, and PASS. No WARNING is showing now.

Comment 11 errata-xmlrpc 2017-10-17 11:45:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2900