Bug 1488363

Summary: [3.6] "when statements should not include jinja2 templating delimiters" warning is shown when running installer with ansible-2.3.1.0-3.el7.noarch
Product: OpenShift Container Platform Reporter: Johnny Liu <jialiu>
Component: InstallerAssignee: Russell Teague <rteague>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: low Docs Contact:
Priority: medium    
Version: 3.6.1CC: aos-bugs, jokerman, mmccomas, rteague
Target Milestone: ---   
Target Release: 3.6.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
With Ansible 2.3 warnings are issued when using Jinja delimiters in 'when' conditions. The delimiters have been removed from the code base to avoid these warnings.
 Story Points: ---
Clone Of: 1480129 Environment:
Last Closed: 2017-10-17 11:45:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1480129    
Bug Blocks: 1488359, 1488360, 1488361    

Description Johnny Liu 2017-09-05 08:24:54 UTC 
+++ This bug was initially created as a clone of Bug #1480129 +++

Description of problem:
When running 3.2 installer with ansible 2.3, a lot of warning is shown up, though it is harmless.


PLAY [Populate config host groups] *********************************************

TASK [fail] ********************************************************************
Thursday 10 August 2017  02:13:09 +0000 (0:00:00.047)       0:00:00.316 ******* 
 [WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: {{ g_etcd_hosts is not defined }}

Pls search "when statements should not include jinja2 templating delimiters" keyword in the attached installation log to find more.


Version-Release number of the following components:
ansible-2.3.1.0-3.el7.noarch
openshift-ansible-3.2.63-1.git.0.a21de5e.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
a lot of warning is shown after switch ansible version from 2.2 to 2.3

Expected results:
No more warning.

Additional info:
Please attach logs from ansible-playbook with the -vvv flag


Description of problem:

Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

--- Additional comment from Johnny Liu on 2017-08-10 05:13 EDT ---



--- Additional comment from Johnny Liu on 2017-08-10 05:59:16 EDT ---

Other version of installer (3.3 ~ 3.6) also has such issues, but the occurrence is less than 3.2.

--- Additional comment from Russell Teague on 2017-08-24 20:21:25 EDT ---

Proposed: https://github.com/openshift/openshift-ansible/pull/5207

--- Additional comment from Russell Teague on 2017-08-29 13:12:14 EDT ---

Merged: https://github.com/openshift/openshift-ansible/pull/5207
Comment 1 Johnny Liu 2017-09-05 08:27:17 UTC 
Test 3.6 using openshift-ansible-3.6.173.0.21-2.git.0.44a4038.el7.noarch, still found the following warning:


PLAY [Populate config host groups] *********************************************

TASK [Evaluate groups - g_etcd_hosts or g_new_etcd_hosts required] *************
Tuesday 05 September 2017  03:51:25 +0000 (0:00:00.025)       0:00:00.110 ***** 
 [WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: {{ g_etcd_hosts is not defined and
g_new_etcd_hosts is not defined}}

skipping: [localhost] => {
    "changed": false, 
    "skip_reason": "Conditional result was False", 
    "skipped": true
}
Comment 2 Russell Teague 2017-09-05 12:33:46 UTC 
Merged: https://github.com/openshift/openshift-ansible/pull/5215
Comment 4 Johnny Liu 2017-09-07 07:32:25 UTC 
Waiting for newer errata puddle to include the fix.
Comment 5 Johnny Liu 2017-09-11 03:19:02 UTC 
Due no AtomicOpenShift-errata puddle including the fix, switch to AtomicOpenShift puddle to do verification.

Verified this bug with openshift-ansible-3.6.173.0.31-1.git.0.c9aeacc.el7.noarch, and PASS.

No warning is shown now.
Comment 6 Johnny Liu 2017-09-15 01:42:13 UTC 
No openshift-ansible build is attached to errata, no errata puddle, move it to "MODIFIED"
Comment 8 Johnny Liu 2017-09-18 10:50:05 UTC 
Verified this bug with openshift-ansible-3.6.173.0.35-1.git.0.6c318bc.el7.noarch, and PASS.

No warning is shown now.
Comment 10 errata-xmlrpc 2017-10-17 11:45:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2900