Bug 1489144

Summary: UEFI installs crash during bootloader installation: "TypeError: must be str, not method"
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, dlehman, jkonecny, jonathan, kellin, kparal, mkolman, pjones, robatino, sbueno, vanmeeuwen+fedora, vpodzime, vponcova, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: AcceptedBlocker
Fixed In Version: anaconda-27.20.1-3.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-11 22:14:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1396702    

Description Adam Williamson 2017-09-06 19:01:53 UTC
With anaconda-28.2-1.fc28 and probably anaconda-27.20.1-2.fc27, UEFI installs crash during bootloader installation, with this traceback:

  File "/usr/lib64/python3.6/site-packages/pyanaconda/threading.py", line 252, in run
    threading.Thread.run(self)

  File "/usr/lib64/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)

  File "/usr/lib64/python3.6/site-packages/pyanaconda/installation.py", line 365, in doInstall
    installation_queue.start()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/installation_tasks.py", line 304, in start
    item.start()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/installation_tasks.py", line 304, in start
    item.start()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/installation_tasks.py", line 472, in start
    self.run_task()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/installation_tasks.py", line 438, in run_task
    self._task(*self._task_args, **self._task_kwargs)

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 2490, in writeBootLoader
    writeBootLoaderFinal(storage, payload, instClass, ksdata)

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 2463, in writeBootLoaderFinal
    storage.bootloader.write()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 1769, in write
    self.install()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 1779, in install
    self.add_efi_boot_target()

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 1730, in add_efi_boot_target
    self._add_single_efi_boot_target(self.stage1_device)  # pylint: disable=no-member

  File "/usr/lib64/python3.6/site-packages/pyanaconda/bootloader.py", line 1722, in _add_single_efi_boot_target
    "-l", self.efi_dir_as_efifs_dir + self._efi_binary,  # pylint: disable=no-member

TypeError: must be str, not method

I have already investigated and filed a fix for this: https://github.com/rhinstaller/anaconda/pull/1176 . But we need a bug report for FE / blocker purposes; we need a newer anaconda build to fix other blockers, but we can't use 27.20.2-1 with this bug in it. Thus proposing this as a Beta release blocker, per Alpha criterion "The installer must be able to complete an installation to a single disk using automatic partitioning" in the case of UEFI installs.

Comment 1 Fedora Update System 2017-09-07 19:13:20 UTC
anaconda-27.20.1-3.fc27 initial-setup-0.3.49-1.fc27 python-simpleline-0.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5361e86979

Comment 2 Fedora Update System 2017-09-07 19:14:16 UTC
anaconda-27.20.1-3.fc27 initial-setup-0.3.49-1.fc27 python-simpleline-0.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5361e86979

Comment 3 Fedora Update System 2017-09-08 15:24:17 UTC
anaconda-27.20.1-3.fc27, initial-setup-0.3.49-1.fc27, python-simpleline-0.5-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5361e86979

Comment 4 Adam Williamson 2017-09-08 22:58:22 UTC
openQA testing suggests this works:

https://openqa.stg.fedoraproject.org/tests/156810

Comment 5 Kamil Páral 2017-09-11 16:34:28 UTC
Discussed during blocker review [1]:

AcceptedBlocker (Beta) - clearly violates several "must be able to complete an install" criteria, in the case of a UEFI install

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2017-09-11/

Comment 6 Fedora Update System 2017-09-11 22:14:21 UTC
anaconda-27.20.1-3.fc27, initial-setup-0.3.49-1.fc27, python-simpleline-0.5-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.