Bug 1489332

Summary: unlock_entity.sh does not report human readable output
Product: [oVirt] ovirt-engine Reporter: Roman Hodain <rhodain>
Component: GeneralAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact: Lucie Leistnerova <lleistne>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1.5CC: bugs, gwatson, lsvaty, mperina
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
rule-engine: planning_ack+
mperina: devel_ack+
pstehlik: testing_ack+
Target Release: 4.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: We have added command line parameter '-c', using which column names will be shown in the output, so administrators will know what entity is identified by showed UUID. Reason: Result:
Story Points: ---
Clone Of: 1489328 Environment:
Last Closed: 2018-02-12 10:09:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Roman Hodain 2017-09-07 08:43:31 UTC
Description of problem:
/usr/share/ovirt-engine/setup/dbutils/unlock_entity.sh does not return human readable output. There is no way for the user to figure out what the returned data is.

Version-Release number of selected component (if applicable):
   4.1.5

How reproducible:
    100%

Steps to Reproduce:
1. lock a disk
2. run # ./unlock_entity.sh -u engine -t disk -q
3.

Actual results:
    Not header is displayed

    # ./unlock_entity.sh -u engine -t disk -q
     6b324a40-6699-454c-8033-6e4070823e92 | 2a3fd3a2-f627-467b-bda0-06dc01e1c982
     6b324a40-6699-454c-8033-6e4070823e92 | 2a3fd3a2-f627-467b-bda0-06dc01e1c982

Expected results:
    
    The result is presented in a way that the it is possible to figure out what the result is, but still keeps ability to be easily parsed.

Comment 2 rhev-integ 2017-11-02 13:38:00 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[No relevant external trackers attached]

For more info please contact: infra

Comment 3 rhev-integ 2017-11-02 21:08:12 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'ovirt-engine-4.2.0_beta1' doesn't contain patch 'https://gerrit.ovirt.org/82812']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.2.0_beta1

For more info please contact: infra

Comment 4 Lucie Leistnerova 2018-01-23 17:42:11 UTC
unlock_entity.sh got -c option (documented in help) that shows header with column names

verified in ovirt-engine-4.2.1.2-0.1.el7.noarch

Comment 6 Sandro Bonazzola 2018-02-12 10:09:47 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.