Bug 1489328 - unlock_entity.sh -q does not support type "all"
Summary: unlock_entity.sh -q does not support type "all"
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 4.1.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Miroslava Voglova
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-07 08:38 UTC by Roman Hodain
Modified: 2018-01-23 04:21 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Previously, administrators had to pass a specific entity type ("vm", "disk", or "snapshot") using the -q option for each unlock_entity.sh invocation, but there was no way to process all entity types within a single invocation. Now, there is a new "all" value which can be passed using the -q option to process all entity types at once.
Clone Of:
: 1489332 1489334 (view as bug list)
Environment:
Last Closed: 2017-12-20 11:04:33 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: planning_ack+
rule-engine: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 82616 0 master MERGED dbutils: implementation of type all -q unlock_entity 2017-10-13 14:20:57 UTC

Description Roman Hodain 2017-09-07 08:38:16 UTC 
Description of problem:
/usr/share/ovirt-engine/setup/dbutils/unlock_entity.sh supports 5 object types vm, template, disk, snapshot and all. But type "all" is not implemented for queries and may be confusing.

Version-Release number of selected component (if applicable):
4.1.5

How reproducible:
100%

Steps to Reproduce:
1. lock a disk
2.
3.

Actual results:
    The following command returns some records:

    # ./unlock_entity.sh -u engine -t disk -q
     6b324a40-6699-454c-8033-6e4070823e92 | 2a3fd3a2-f627-467b-bda0-06dc01e1c982
     6b324a40-6699-454c-8033-6e4070823e92 | 2a3fd3a2-f627-467b-bda0-06dc01e1c982

    But inthe same time the following command does not report anything:

    # ./unlock_entity.sh -u engine -t all -q


Expected results:
    
    When querying type all, all locked object should be reported.
Comment 1 Radim Hrazdil 2017-12-14 11:26:01 UTC 
Verified that all types of object are reported when using 'all' type option. Version RHVM 4.2.0-6. 

[root@system-ge-3 dbutils]# ./unlock_entity.sh -q -t all; echo "---"; ./unlock_entity.sh -q -t disk
Locked VMs:

Locked templates:

Locked disks:
 fff5df59-32bc-4fe8-b604-2d8db0e972b3 | 5f6e1aa3-4db1-4c94-a65e-a08a2fe21579

Locked snapshots:

---
 fff5df59-32bc-4fe8-b604-2d8db0e972b3 | 5f6e1aa3-4db1-4c94-a65e-a08a2fe21579
Comment 2 Sandro Bonazzola 2017-12-20 11:04:33 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.