Bug 1489798

Summary: Toast notifications missing error icon
Product: Red Hat CloudForms Management Engine Reporter: Ryan Spagnola <rspagnol>
Component: UI - OPSAssignee: Dávid Halász <dhalasz>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: dhalasz, hkataria, jhardy, mmojzis, mpovolny, obarenbo, rspagnol, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: ui:automate:notification
Fixed In Version: 5.9.0.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1503611 (view as bug list) Environment:
Last Closed: 2018-03-06 14:49:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1503611    
Attachments:
Description Flags
screenshot
none
error font icon none

Description Ryan Spagnola 2017-09-08 12:07:32 UTC 
Description of problem:
Error notifications are missing error icon

Version-Release number of selected component (if applicable):
5.8.1.5

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
See attached screenshot

~~~
$evm.create_notification!(
  message: 'Failed!',
  subject: vm,
  type: 'automate_user_error'
)
Comment 2 Ryan Spagnola 2017-09-08 12:08:12 UTC 
Created attachment 1323710 [details]
screenshot
Comment 4 Eric Winchell 2017-09-27 13:46:29 UTC 
Created attachment 1331452 [details]
error font icon
Comment 6 CFME Bot 2017-10-17 13:53:52 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/2426
Comment 7 CFME Bot 2017-10-17 15:28:58 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/57c2527668ca3ee9ad9865768b5c7f67b9fe6d60

commit 57c2527668ca3ee9ad9865768b5c7f67b9fe6d60
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Oct 17 15:34:27 2017 +0200
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue Oct 17 15:34:27 2017 +0200

    Notification type error should be rendered in patternfly as danger
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1489798

 .../javascripts/services/event_notifications_service.js       | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Comment 9 Matouš Mojžíš 2017-11-30 15:02:21 UTC 
Hi,
how can I reproduce it?
Can I somehow evoke this notification?
Thanks!
Comment 10 Dávid Halász 2017-11-30 15:22:12 UTC 
From a rails console (bin/rails c):
Notification.create(:type => :automate_user_error, :initiator => User.first, :options => { :message => 'hello' })
Comment 11 Matouš Mojžíš 2017-11-30 15:49:53 UTC 
Verified in 5.9.0.11. 
Tried to run automate_global_error and automate_user_error from rails console and both these notifications were shown with red cross image.