Bug 1489798 - Toast notifications missing error icon
Summary: Toast notifications missing error icon
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: All
OS: All
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Dávid Halász
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui:automate:notification
Depends On:
Blocks: 1503611
TreeView+ depends on / blocked
 
Reported: 2017-09-08 12:07 UTC by Ryan Spagnola
Modified: 2021-06-10 12:58 UTC (History)
8 users (show)

Fixed In Version: 5.9.0.3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1503611 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:49:50 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (28.38 KB, image/png)
2017-09-08 12:08 UTC, Ryan Spagnola
no flags Details
error font icon (59.41 KB, image/png)
2017-09-27 13:46 UTC, Eric Winchell
no flags Details

Description Ryan Spagnola 2017-09-08 12:07:32 UTC
Description of problem:
Error notifications are missing error icon

Version-Release number of selected component (if applicable):
5.8.1.5

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
See attached screenshot

~~~
$evm.create_notification!(
  message: 'Failed!',
  subject: vm,
  type: 'automate_user_error'
)

Comment 2 Ryan Spagnola 2017-09-08 12:08:12 UTC
Created attachment 1323710 [details]
screenshot

Comment 4 Eric Winchell 2017-09-27 13:46:29 UTC
Created attachment 1331452 [details]
error font icon

Comment 7 CFME Bot 2017-10-17 15:28:58 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/57c2527668ca3ee9ad9865768b5c7f67b9fe6d60

commit 57c2527668ca3ee9ad9865768b5c7f67b9fe6d60
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Oct 17 15:34:27 2017 +0200
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue Oct 17 15:34:27 2017 +0200

    Notification type error should be rendered in patternfly as danger
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1489798

 .../javascripts/services/event_notifications_service.js       | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comment 9 Matouš Mojžíš 2017-11-30 15:02:21 UTC
Hi,
how can I reproduce it?
Can I somehow evoke this notification?
Thanks!

Comment 10 Dávid Halász 2017-11-30 15:22:12 UTC
From a rails console (bin/rails c):
Notification.create(:type => :automate_user_error, :initiator => User.first, :options => { :message => 'hello' })

Comment 11 Matouš Mojžíš 2017-11-30 15:49:53 UTC
Verified in 5.9.0.11. 
Tried to run automate_global_error and automate_user_error from rails console and both these notifications were shown with red cross image.


Note You need to log in before you can comment on or make changes to this bug.