Bug 1490202

Summary: [downstream clone - 4.1.7] [iSCSI] ovirt-hosted-engine-setup fails if none of the discovered target is associated to the accessed portal
Product: Red Hat Enterprise Virtualization Manager Reporter: rhev-integ
Component: ovirt-hosted-engine-setupAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED ERRATA QA Contact: Nikolai Sednev <nsednev>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.1.5CC: bgraveno, lsurette, stirabos, ykaul, ylavi
Target Milestone: ovirt-4.1.7Keywords: EasyFix, Triaged, ZStream
Target Release: ---Flags: lsvaty: testing_plan_complete-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously, ovirt-hosted-engine-setup would fail due to a bad multipath configuration on SAN side if the user tries to access an iSCSI portal where iSCSI discovery finds the targets, but not one of them are associated with the accessed portal. This issue has now been fixed.
Story Points: ---
Clone Of: 1487560 Environment:
Last Closed: 2017-11-07 17:26:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1487560    
Bug Blocks: 1493544    

Description rhev-integ 2017-09-11 05:29:08 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1487560 +++
======================================================================

Description of problem:
ovirt-hosted-engine-setup is currently failing if, due to a bad multipath configuration on SAN side, the user tries to access an iSCSI portal where iSCSI discovery finds targets but not one of them is associated with the accessed portal.

Example:
2017-08-31 12:59:04 DEBUG otopi.plugins.otopi.dialog.machine dialog.__logString:204 DIALOG:SEND       ### Please specify the iSCSI portal IP address: 
2017-08-31 12:59:12 DEBUG otopi.plugins.otopi.dialog.machine dialog.__logString:204 DIALOG:RECEIVE    192.168.96.205

2017-08-31 12:59:23 DEBUG otopi.plugins.gr_he_setup.storage.blockd blockd._iscsi_discovery:320 {'status': {'message': 'Done', 'code': 0}, 'items': [u'192.168.96.206:3260,2460 iqn.2007-11.***.************:************-01-v04c505ca8ddf8aed.000000a2.891a8f27', u'192.168.96.207:3260,2460 iqn.2007-11.***.************:************-01-v04c505ca8ddf8aed.000000a2.891a8f27', u'192.168.96.206:3260,2460 iqn.2007-11.***.************:************-02-v04c505ca8ddf8aed.000000a3.891a8f27', u'192.168.96.207:3260,2460 iqn.2007-11.***.************:************-02-v04c505ca8ddf8aed.000000a3.891a8f27']}
2017-08-31 12:59:23 DEBUG otopi.plugins.gr_he_setup.storage.blockd blockd._iscsi_discovery:337 found: []

And then the code fails on:
2017-08-31 12:45:23 DEBUG otopi.plugins.gr_he_setup.storage.blockd
blockd._iscsi_discovery:337 found: []
2017-08-31 12:45:23 DEBUG otopi.context context._executeMethod:142
method exception
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 132,
in _executeMethod
    method['method']()
  File "/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/gr-he-setup/storage/blockd.py",
line 611, in _customization
    default=valid_targets[0]
IndexError: list index out of range

Version-Release number of selected component (if applicable):
4.1.5

How reproducible:
100%

Steps to Reproduce:
1. run hosted-engine-setup ad try to connect to an iSCSI portal that reports just targets associated to other portals
2.
3.

Actual results:
line 611, in _customization
    default=valid_targets[0]
IndexError: list index out of range

Expected results:
It loops till the user enters a valid configuration

Additional info:

(Originally by Simone Tiraboschi)

Comment 4 Nikolai Sednev 2017-09-26 15:37:50 UTC
Forth to our testing with Simone, we've got successfully deployed SHE over iSCSI and did not get this bug reproduced on latest ovirt-hosted-engine-setup-2.1.4-1.el7ev.noarch. Moving to verified. Please reopen if you still getting this issue.

Comment 6 errata-xmlrpc 2017-11-07 17:26:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:3135

Comment 7 Daniel Gur 2019-08-28 13:13:22 UTC
sync2jira

Comment 8 Daniel Gur 2019-08-28 13:17:35 UTC
sync2jira