Bug 1490272

Summary: Failed to start dwh service on NumberFormatException: For input string: "6.1"
Product: [oVirt] ovirt-engine-dwh Reporter: Lukas Svaty <lsvaty>
Component: ServicesAssignee: Shirly Radco <sradco>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: medium    
Version: 4.1.6CC: bugs, didi, knarra, lsvaty
Target Milestone: ovirt-4.1.6Keywords: AutomationBlocker, Regression
Target Release: 4.1.7Flags: rule-engine: ovirt-4.1+
rule-engine: ovirt-4.2+
rule-engine: blocker+
lsvaty: testing_plan_complete+
rule-engine: planning_ack+
sradco: devel_ack+
pstehlik: testing_ack+
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: ovirt-engine-dwh-4.1.7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-19 10:03:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Metrics RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1478859    
Attachments:
Description Flags
Setup log of upgrading remote dwh service none

Description Lukas Svaty 2017-09-11 08:16:49 UTC 
Description of problem:
After restart of dwh service, it is stopped on NumberFormatException

Version-Release number of selected component (if applicable):
ovirt-engine-dwh-4.1.6.1-2.el7ev.noarch

Steps to Reproduce:
1. service ovirt-engine-dwhd restart
2. service ovirt-engine-dwhd restart
3. check /var/log/ovirt-engine-dwhd/ovirt-engine-dwhd.log

Actual results:
service stopped

Expected results:
service running

Additional info:
Log:
ovirtEngineDbDriverClass|org.postgresql.Driver
ovirtEngineHistoryDbJdbcConnection|jdbc:postgresql://localhost:5432/ovirt_engine_history?sslfactory=org.postgresql.ssl.NonValidatingFactory
hoursToKeepDaily|0
hoursToKeepHourly|720
ovirtEngineDbPassword|**********************
runDeleteTime|3
ovirtEngineDbJdbcConnection|jdbc:postgresql://localhost:5432/engine?sslfactory=org.postgresql.ssl.NonValidatingFactory
runInterleave|60
limitRows|limit 1000
ovirtEngineHistoryDbUser|ovirt_engine_history
ovirtEngineDbUser|engine
deleteIncrement|10
timeBetweenErrorEvents|300000
hoursToKeepSamples|24
deleteMultiplier|1000
lastErrorSent|2011-07-03 12:46:47.000000
etlVersion|4.1.6.1
dwhAggregationDebug|false
dwhUuid|dba566f9-e5d1-42a3-a03e-e5d584e9b85e
ovirtEngineHistoryDbDriverClass|org.postgresql.Driver
ovirtEngineHistoryDbPassword|**********************
Exception in component tJDBCInput_1
java.lang.NumberFormatException: For input string: "6.1"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:580)
	at java.lang.Integer.parseInt(Integer.java:615)
	at ovirt_engine_dwh.minimalversioncheck_4_1.MinimalVersionCheck.tJDBCInput_1Process(MinimalVersionCheck.java:1225)
	at ovirt_engine_dwh.minimalversioncheck_4_1.MinimalVersionCheck.tJDBCConnection_2Process(MinimalVersionCheck.java:782)
	at ovirt_engine_dwh.minimalversioncheck_4_1.MinimalVersionCheck.tJDBCConnection_1Process(MinimalVersionCheck.java:657)
	at ovirt_engine_dwh.minimalversioncheck_4_1.MinimalVersionCheck.runJobInTOS(MinimalVersionCheck.java:3089)
	at ovirt_engine_dwh.minimalversioncheck_4_1.MinimalVersionCheck.runJob(MinimalVersionCheck.java:2853)
	at ovirt_engine_dwh.historyetl_4_1.HistoryETL.tRunJob_2Process(HistoryETL.java:8163)
	at ovirt_engine_dwh.historyetl_4_1.HistoryETL$3.run(HistoryETL.java:11674)
2017-09-11 10:14:32|nYj3i5|iRV95i|iRV95i|OVIRT_ENGINE_DWH|MinimalVersionCheck|Default|6|Java Exception|tJDBCInput_1|java.lang.NumberFormatException:For input string: "6.1"|1
Exception in component tRunJob_2
java.lang.RuntimeException: Child job running failed
	at ovirt_engine_dwh.historyetl_4_1.HistoryETL.tRunJob_2Process(HistoryETL.java:8186)
	at ovirt_engine_dwh.historyetl_4_1.HistoryETL$3.run(HistoryETL.java:11674)
2017-09-11 10:14:32|iRV95i|iRV95i|iRV95i|OVIRT_ENGINE_DWH|HistoryETL|Default|6|Java Exception|tRunJob_2|java.lang.RuntimeException:Child job running failed|1
2017-09-11 10:14:32|ETL Service Stopped
Comment 1 Lukas Svaty 2017-09-11 12:59:55 UTC 
also tested on remote dwh service, during engine-setup

[ ERROR ] Failed to execute stage 'Setup validation': invalid literal for int() with base 10: '6.1' seems like the same issue
Comment 2 Yedidyah Bar David 2017-09-11 13:54:47 UTC 
(In reply to Lukas Svaty from comment #1)
> also tested on remote dwh service, during engine-setup
> 
> [ ERROR ] Failed to execute stage 'Setup validation': invalid literal for
> int() with base 10: '6.1' seems like the same issue

Please attach setup logs, thanks.
Comment 3 Lukas Svaty 2017-09-11 14:07:01 UTC 
Created attachment 1324484 [details]
Setup log of upgrading remote dwh service
Comment 4 Lukas Svaty 2017-09-11 15:00:38 UTC 
(In reply to Lukas Svaty from comment #1)
> also tested on remote dwh service, during engine-setup
> 
> [ ERROR ] Failed to execute stage 'Setup validation': invalid literal for
> int() with base 10: '6.1' seems like the same issue

Checked the commit on demand. This issue is solved by commit 81627, however after restart dwh is still failing with traceback from the description.
Comment 5 Lukas Svaty 2017-09-11 15:03:01 UTC 
Also as suggested per conversation offline, I suggest adding a check for the restart of ovirt-engine-dwhd service to Ovirt System Tests.
Comment 6 Red Hat Bugzilla Rules Engine 2017-09-12 06:34:54 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 7 Lukas Svaty 2017-09-12 16:09:00 UTC 
verified in:

ovirt-engine-dwh-setup-4.1.7-1.el7ev.noarch
ovirt-engine-dwh-4.1.7-1.el7ev.noarch
Comment 8 Yedidyah Bar David 2017-10-17 07:34:47 UTC 
I'd like to clarify that we didn't fix this bug in 4.1, only in master (4.2).

In 4.1, we built 4.1.7 for oVirt/RHV 4.1.6, and will build 4.1.8 for 4.1.7.

There is no inherent problem in having non-matching version numbers between components. Indeed, in some projects, we try to align, but in others we don't - e.g. otopi, ovirt-host-deploy, ovirt-hosted-engine-setup never had matching version numbers. Even DWH, that does, does not release new versions solely for the matching. So e.g. in 4.0.2 engine and dwh matched, but engine 4.0.3 and 4.0.4 was released without a matching dwh - so used 4.0.2.
Comment 9 RamaKasturi 2017-10-17 11:08:36 UTC 
*** Bug 1491125 has been marked as a duplicate of this bug. ***