Bug 1491501
| Summary: | SSM Alter system group memberships page - cannot change page | ||
|---|---|---|---|
| Product: | [Community] Spacewalk | Reporter: | Andrew Bergman <andy> |
| Component: | WebUI | Assignee: | Grant Gainey <ggainey> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Satellite QA List <satqe-list> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 2.6 | CC: | ben.roberts |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | spacewalk-java-2.8.55-1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-20 12:31:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1450111, 1564160 | ||
|
Description
Andrew Bergman
2017-09-14 02:41:29 UTC
Also seeing this problem, but with slightly different behaviour. Clicking the > or >> buttons acts as though the "Alter Membership" button was pressed, and I get taken to the confirmation page with no changes to confirm. I worked around the issue on this occasion by renaming the group to make it appear at the top of the list, then renamed it back after adding the systems. Fun. The root issue here is that the ssm/groups/Manage (and its confirm) JSPs rely on the 'new list tag' (rl:list), but the struts-action for them is based on old-list-tag behavior. This has been the case since the pages were ported from Perl to Java several years ago. Added correct pagination-decorator and naming in JSPs, reworked struts-actions to Do The Right Thing. Testing: * register a system * create 15 server groups * select the system * Go to Manage -> Manage Server Groups to get to ssm/groups/manage EXPECTED: * List has "items per page" pulldown * List has correct "1-N of M" and pagination buttons Testing: * Select 'Add' radio for one system-group * Select 'Remove' for another * page elsewhere, go back, change items-per-page EXPECTED: * Specified server-groups retain the appropriate Add/Remove radio buttons Testing: * Repeat for system-groups on other pages EXPECTED: * as above Testing: * Choose "Alter Membership" EXPECTED: * Confirm page * Two lists, one for 'Add' and one for 'Remove' * Both lists can be paginated separately * Both lists can have their 'items per page' set separately * Lists show correct system-groups set to Add or Remove * Page shows correct number of systems in SSM-selection Testing: * Choose 'Confirm' EXPECTED: * Page to ssm/groups/Manage * "System Group Membership changed" message * All groups should be back to "No Change" * SSM systems should now be added to all Add groups, and have been removed from all Remove groups NOTE: The RhnSet that holds the user-choices being made on ssm/groups/Manage is persistent. It is cleared on pushing 'Confirm'. spacewalk.github: ea8ca855445848d48e772e468906e779fe6dc26b spacewalk.github: bf5a474026058fbbc3a60b4a781ec81324d4a482 Added alphabar and filter to system-group-list as well. NOTE - needs the changes for all affected pages to work. DO NOT use separately. Moving ON_QA Spacewalk 2.8 has been released. https://github.com/spacewalkproject/spacewalk/wiki/ReleaseNotes28 |