Bug 1491501 - SSM Alter system group memberships page - cannot change page
Summary: SSM Alter system group memberships page - cannot change page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: WebUI
Version: 2.6
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Grant Gainey
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: sat58-errata space28
TreeView+ depends on / blocked
 
Reported: 2017-09-14 02:41 UTC by Andrew Bergman
Modified: 2018-04-20 12:31 UTC (History)
1 user (show)

Fixed In Version: spacewalk-java-2.8.55-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-20 12:31:21 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1534021 0 unspecified CLOSED SystemGroupList says it can sort-by-systems - but it lies 2021-02-22 00:41:40 UTC

Internal Links: 1534021

Description Andrew Bergman 2017-09-14 02:41:29 UTC
Description of problem:

Using multiple systems selected and managed, in SSM click "manage groups".
I cannot change page using the controls above and below on right hand side of System groups list.  Also, a drop down to change maximum entries to display is missing for this page and would be useful. 
 
Version-Release number of selected component (if applicable):

2.6

How reproducible:

Every time and on multiple browsers (IE 11.0.9600.18762 and Chrome Version 60.0.3112.101 on Win7 64

Steps to Reproduce:
1.Select multiple systems and manage in SSM
2.Click "manage groups"
3.Click on > and >> buttons to move between pages

Actual results:
No new pages are loaded, user remains on first page.

Expected results:
Progression to next page on click of > button, or last page using >> button.

Additional info:

Comment 1 Ben Roberts 2018-01-09 13:04:05 UTC
Also seeing this problem, but with slightly different behaviour. Clicking the > or >> buttons acts as though the "Alter Membership" button was pressed, and I get taken to the confirmation page with no changes to confirm.

I worked around the issue on this occasion by renaming the group to make it appear at the top of the list, then renamed it back after adding the systems.

Comment 2 Grant Gainey 2018-01-11 14:44:29 UTC
Fun. The root issue here is that the ssm/groups/Manage (and its confirm) JSPs rely on the 'new list tag' (rl:list), but the struts-action for them is based on old-list-tag behavior. This has been the case since the pages were ported from Perl to Java several years ago.

Added correct pagination-decorator and naming in JSPs, reworked struts-actions to Do The Right Thing.

Testing:
* register a system
* create 15 server groups
* select the system
* Go to Manage -> Manage Server Groups to get to ssm/groups/manage

EXPECTED:
* List has "items per page" pulldown
* List has correct "1-N of M" and pagination buttons

Testing:
* Select 'Add' radio for one system-group
* Select 'Remove' for another
* page elsewhere, go back, change items-per-page

EXPECTED:
* Specified server-groups retain the appropriate Add/Remove radio buttons

Testing:
* Repeat for system-groups on other pages

EXPECTED:
* as above

Testing:
* Choose "Alter Membership"

EXPECTED:
* Confirm page
* Two lists, one for 'Add' and one for 'Remove'
* Both lists can be paginated separately
* Both lists can have their 'items per page' set separately
* Lists show correct system-groups set to Add or Remove
* Page shows correct number of systems in SSM-selection

Testing:
* Choose 'Confirm'

EXPECTED:
* Page to ssm/groups/Manage
* "System Group Membership changed" message
* All groups should be back to "No Change"
* SSM systems should now be added to all Add groups, and have been removed from all Remove groups

NOTE:
The RhnSet that holds the user-choices being made on ssm/groups/Manage is persistent. It is cleared on pushing 'Confirm'.

spacewalk.github:
ea8ca855445848d48e772e468906e779fe6dc26b

Comment 3 Grant Gainey 2018-01-12 20:21:26 UTC
spacewalk.github:
bf5a474026058fbbc3a60b4a781ec81324d4a482

Added alphabar and filter to system-group-list as well.

Comment 4 Grant Gainey 2018-01-12 20:37:32 UTC
NOTE - needs the changes for all affected pages to work. DO NOT use separately.

Comment 5 Jiří Dostál 2018-03-26 12:16:33 UTC
Moving ON_QA

Comment 6 Jiří Dostál 2018-04-20 12:31:21 UTC
Spacewalk 2.8 has been released.
https://github.com/spacewalkproject/spacewalk/wiki/ReleaseNotes28


Note You need to log in before you can comment on or make changes to this bug.