Bug 1492026

Summary:	set the shard-block-size to 64MB in virt profile
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	amukherj, bugs, rcyriac, rhinduja, rhs-bugs, sabose, sasundar, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1489823	Environment:
Last Closed:	2017-10-13 12:46:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1489823
Bug Blocks:	1468969, 1491574

Description Krutika Dhananjay 2017-09-15 09:46:36 UTC

+++ This bug was initially created as a clone of Bug #1489823 +++

+++ This bug was initially created as a clone of Bug #1468969 +++

Description of problem:
-----------------------
The better performance was observed with the shard-size of 128MB.
Virt profile should have this attribute and so its set on the volume when the volume is optimized for virt-profile

Version-Release number of selected component (if applicable):
-------------------------------------------------------------


How reproducible:
-----------------
NA

Steps to Reproduce:
-------------------
NA

Actual results:
---------------
Shard-size is set to 4MB

Expected results:
-----------------
shard-size should be set to 128MB so that perf improvement is observed

--- Additional comment from SATHEESARAN on 2017-07-10 02:52:40 EDT ---

At the moment, performance tests are done with different values and the value is yet to finalized based on the perf tests


--- Additional comment from Atin Mukherjee on 2017-09-07 06:32:37 EDT ---

When would the recommended shard-size can be provided so that the required changes can be done?

--- Additional comment from SATHEESARAN on 2017-09-07 06:34:14 EDT ---

(In reply to Atin Mukherjee from comment #4)
> When would the recommended shard-size can be provided so that the required
> changes can be done?

The recommended value is 64MB

--- Additional comment from Worker Ant on 2017-09-08 08:35:56 EDT ---

REVIEW: https://review.gluster.org/18243 (features/shard: Change default shard-block-size to 64MB) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-09-13 05:37:32 EDT ---

REVIEW: https://review.gluster.org/18243 (features/shard: Change default shard-block-size to 64MB) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-09-13 08:46:42 EDT ---

REVIEW: https://review.gluster.org/18243 (features/shard: Change default shard-block-size to 64MB) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-09-13 23:23:19 EDT ---

COMMIT: https://review.gluster.org/18243 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit e4a59b384f5bbaaeb937a53cef64f4e388f85153
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Sep 8 18:04:50 2017 +0530

    features/shard: Change default shard-block-size to 64MB
    
    Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
    BUG: 1489823
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: https://review.gluster.org/18243
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Sunil Kumar Acharya <sheggodu>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-09-15 09:59:39 UTC

REVIEW: https://review.gluster.org/18305 (features/shard: Change default shard-block-size to 64MB) posted (#1) for review on release-3.12 by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2017-09-15 11:04:34 UTC

REVIEW: https://review.gluster.org/18305 (features/shard: Change default shard-block-size to 64MB) posted (#2) for review on release-3.12 by Krutika Dhananjay (kdhananj)

Comment 3 Worker Ant 2017-09-28 20:53:50 UTC

COMMIT: https://review.gluster.org/18305 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit bfc8b09f233a3dfcce776da37389b6c83e4d85dc
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Sep 8 18:04:50 2017 +0530

    features/shard: Change default shard-block-size to 64MB
    
            Backport of:
            > Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
            > BUG: 1489823
            > Reviewed-on: https://review.gluster.org/18243
            > cherry picked from commit e4a59b384f5bbaaeb937a53cef64f4e388f85153
    
    Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
    BUG: 1492026
    Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 4 Jiffin 2017-10-13 12:46:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.2, please open a new bug report.

glusterfs-glusterfs-3.12.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-October/032684.html
[2] https://www.gluster.org/pipermail/gluster-users/