Bug 1492490

Summary:	[downstream clone - 4.1.7] [ovirt-ansible-roles] ovirt-vm-infra: memory_guaranteed value in template don't allow user to specify lower value in memory
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	ovirt-ansible-roles	Assignee:	Ondra Machacek <omachace>
Status:	CLOSED ERRATA	QA Contact:	Petr Kubica <pkubica>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.5	CC:	mgoldboi, mperina, pstehlik
Target Milestone:	ovirt-4.1.7	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-ansible-roles-1.0.4-1.el7ev	Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:	1490852	Environment:
Last Closed:	2017-11-07 17:27:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1490852
Bug Blocks:

Description rhev-integ 2017-09-17 19:41:15 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1490852 +++
======================================================================

Description of problem:
In Webadmin when user are creating VM from template, he can change memory value to whatever he wants. So for example: when template has 4 GiB of guaranteed memory in resource allocation, user can specify memory value to 2 GiB and VM can be created - memory_guaranteed value was automatically changed to lower value

In role when user will use lower value in variable memory, it will fail with fact that the memory value is lower than memory_guaranteed but user can't specify memory_guaranteed value

so I see issue in:
- user can't specify memory_guaranteed value to override this
- if memory value was specified and memory_guaranteed not, role should recalculate memory_guaranteed value as webadmin (same behavior)

Version-Release number of selected component (if applicable):
ovirt-ansible-roles-1.0.3-1.el7ev.noarch
ansible-2.3.2.0-2.el7.noarch

(Originally by Petr Kubica)

Comment 1 rhev-integ 2017-09-17 19:41:16 UTC

>  user can't specify memory_guaranteed value to override this

I agree with this. We need to add it.

- if memory value was specified and memory_guaranteed not, role should recalculate memory_guaranteed value as webadmin (same behavior)

Martin, do we want this behavior?

(Originally by Ondra Machacek)

Comment 2 rhev-integ 2017-09-17 19:41:18 UTC

I've added a documentation that memory param shouldn't be less then memory_guaranteed param, user need to pass those parameter correctly otherwise we fail.

(Originally by Ondra Machacek)

Comment 4 rhev-integ 2017-09-17 19:41:23 UTC

I've added a documentation that memory param shouldn't be less then memory_guaranteed param, user need to pass those parameter correctly otherwise we fail.

(Originally by Ondra Machacek)

Comment 6 Petr Kubica 2017-10-18 06:06:44 UTC

Verified in
ansible-2.3.2.0-2.el7.noarch
ovirt-ansible-roles-1.0.4-1.el7ev.noarch

Comment 8 errata-xmlrpc 2017-11-07 17:27:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:3137