Bug 1490852 - [ovirt-ansible-roles] ovirt-vm-infra: memory_guaranteed value in template don't allow user to specify lower value in memory
Summary: [ovirt-ansible-roles] ovirt-vm-infra: memory_guaranteed value in template don...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-ansible-roles
Version: 4.1.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Ondra Machacek
QA Contact: Petr Kubica
URL:
Whiteboard:
Depends On:
Blocks: 1492490
TreeView+ depends on / blocked
 
Reported: 2017-09-12 11:36 UTC by Petr Kubica
Modified: 2019-05-16 13:11 UTC (History)
3 users (show)

Fixed In Version: ovirt-ansible-roles-1.1.1-0.el7ev
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
: 1492490 (view as bug list)
Environment:
Last Closed: 2018-05-15 18:00:33 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github https://github.com/oVirt ovirt-ansible pull 81 0 None None None 2017-09-14 10:11:05 UTC
Red Hat Product Errata RHEA-2018:1534 0 None None None 2018-05-15 18:01:05 UTC

Description Petr Kubica 2017-09-12 11:36:32 UTC
Description of problem:
In Webadmin when user are creating VM from template, he can change memory value to whatever he wants. So for example: when template has 4 GiB of guaranteed memory in resource allocation, user can specify memory value to 2 GiB and VM can be created - memory_guaranteed value was automatically changed to lower value

In role when user will use lower value in variable memory, it will fail with fact that the memory value is lower than memory_guaranteed but user can't specify memory_guaranteed value

so I see issue in:
- user can't specify memory_guaranteed value to override this
- if memory value was specified and memory_guaranteed not, role should recalculate memory_guaranteed value as webadmin (same behavior)

Version-Release number of selected component (if applicable):
ovirt-ansible-roles-1.0.3-1.el7ev.noarch
ansible-2.3.2.0-2.el7.noarch

Comment 1 Ondra Machacek 2017-09-12 12:53:47 UTC
>  user can't specify memory_guaranteed value to override this

I agree with this. We need to add it.

- if memory value was specified and memory_guaranteed not, role should recalculate memory_guaranteed value as webadmin (same behavior)

Martin, do we want this behavior?

Comment 2 Ondra Machacek 2017-09-14 10:11:06 UTC
I've added a documentation that memory param shouldn't be less then memory_guaranteed param, user need to pass those parameter correctly otherwise we fail.

Comment 4 Petr Kubica 2018-01-03 12:06:29 UTC
ovirt-ansible-vm-infra-1.1.3-1.el7ev.noarch
ansible-2.4.1.0-1.el7ae.noarch

Comment 9 errata-xmlrpc 2018-05-15 18:00:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1534

Comment 10 Franta Kust 2019-05-16 13:05:27 UTC
BZ<2>Jira Resync


Note You need to log in before you can comment on or make changes to this bug.