Bug 1493937 (plasma-drkonqi)
| Summary: | Review Request: plasma-drkonqi - crash handler for KF5/Plasma5 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Kyral <mkyral> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jgrulich, package-review, rdieter |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-10-17 14:10:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Martin Kyral
2017-09-21 07:57:09 UTC
1) URL for SRPM doesn't work 2) I think that this is useless: Obsoletes: plasma-workspace < 5.4.2-2 3) Missing to install installdbgsymbols_fedora.sh to libexec dir, which we have installed together with plasma-workspace-drkonqi 4) You don't need to run /sbin/ldconfig The Obsoletes: plasma-workspace-drkonqi should also be versioned, something like: Obsoletes: plasma-workspace-drkonqi < 5.10.95 And you may also want to add a:
Provides: plasma-workspace-drkonqi = %{version}-%{release}
so that people trying to install the old package name will get the new package.
Thanks for the feedback! The changes were made to the package: spec: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/plasma-drkonqi.spec?h=f26 patch: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/drkonqi-installdbgsymbols.patch?h=f26 srpm: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-26-x86_64/00613357-plasma-drkonqi/plasma-drkonqi-5.10.95-1.fc26.src.rpm Looks good now. All issues have been fixed. Approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-drkonqi plasma-drkonqi landed in rawhide. Time to close the review bug? yep, closing |