Description of problem: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/plasma-drkonqi.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-26-x86_64/00604336-plasma-drkonqi/plasma-drkonqi-5.10.95-0.1.fc26.src.rpm Description: DrKonqi crash handler for KF5/Plasma5 Fedora Account System Username: mkyral Version-Release number of selected component (if applicable): 5.10.95 Additional info: Drkonqi has been split from plasma-workspace into a component of its own in Plasma 5.11. To be imported in rawhide together with the rest of Plasma 5.11 (beta or final)
1) URL for SRPM doesn't work 2) I think that this is useless: Obsoletes: plasma-workspace < 5.4.2-2 3) Missing to install installdbgsymbols_fedora.sh to libexec dir, which we have installed together with plasma-workspace-drkonqi 4) You don't need to run /sbin/ldconfig
The Obsoletes: plasma-workspace-drkonqi should also be versioned, something like: Obsoletes: plasma-workspace-drkonqi < 5.10.95
And you may also want to add a: Provides: plasma-workspace-drkonqi = %{version}-%{release} so that people trying to install the old package name will get the new package.
Thanks for the feedback! The changes were made to the package: spec: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/plasma-drkonqi.spec?h=f26 patch: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/drkonqi-installdbgsymbols.patch?h=f26 srpm: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-26-x86_64/00613357-plasma-drkonqi/plasma-drkonqi-5.10.95-1.fc26.src.rpm
Looks good now. All issues have been fixed. Approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-drkonqi
plasma-drkonqi landed in rawhide. Time to close the review bug?
yep, closing