Bug 1493975

Summary:	disallow replace brick operation on plain distribute volume
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1489432	Environment:
Last Closed:	2017-10-13 12:46:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1489432
Bug Blocks:	1491574

Description Atin Mukherjee 2017-09-21 09:06:55 UTC

+++ This bug was initially created as a clone of Bug #1489432 +++

Description of problem:

disallow replace brick operation on plain distribute volume as it would lead to a data loss.

Version-Release number of selected component (if applicable):
mainline

--- Additional comment from Worker Ant on 2017-09-07 10:10:45 EDT ---

REVIEW: https://review.gluster.org/18226 (glusterd: disallow replace brick for dist only volumes) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-09-08 03:09:03 EDT ---

REVIEW: https://review.gluster.org/18226 (glusterd: disallow replace brick for dist only volumes) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-09-18 09:22:20 EDT ---

REVIEW: https://review.gluster.org/18226 (glusterd: disallow replace brick for dist only volumes) posted (#3) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-09-18 22:54:14 EDT ---

COMMIT: https://review.gluster.org/18226 committed in master by Atin Mukherjee (amukherj) 
------
commit 7f70d38b66ce755f848ff0197814457a28b321df
Author: Atin Mukherjee <amukherj>
Date:   Thu Sep 7 19:14:23 2017 +0530

    glusterd: disallow replace brick for dist only volumes
    
    Allowing replace-brick on dist only volumes will lead to data loss. This
    patch blocks replace brick commit force to fail if a volume is dist
    only.
    
    Also removing tests/basic/pump.t as its of no use as per the discussion
    in
    http://lists.gluster.org/pipermail/gluster-devel/2017-September/053652.html
    
    Change-Id: Iabb0c16f865f3fc361b64a19bfcf0c0fbb5c2682
    BUG: 1489432
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/18226
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: N Balachandran <nbalacha>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-09-21 09:07:21 UTC

REVIEW: https://review.gluster.org/18334 (glusterd: disallow replace brick for dist only volumes) posted (#1) for review on release-3.12 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2017-10-12 05:39:02 UTC

COMMIT: https://review.gluster.org/18334 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit 08e083ac43f3b35892df808f41d4f9fbe6c2154b
Author: Atin Mukherjee <amukherj>
Date:   Thu Sep 7 19:14:23 2017 +0530

    glusterd: disallow replace brick for dist only volumes
    
    Allowing replace-brick on dist only volumes will lead to data loss. This
    patch blocks replace brick commit force to fail if a volume is dist
    only.
    
    Also removing tests/basic/pump.t as its of no use as per the discussion
    in
    http://lists.gluster.org/pipermail/gluster-devel/2017-September/053652.html
    
    >Reviewed-on: https://review.gluster.org/18226
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: N Balachandran <nbalacha>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >(cherry picked from commit 7f70d38b66ce755f848ff0197814457a28b321df)
    
    Change-Id: Iabb0c16f865f3fc361b64a19bfcf0c0fbb5c2682
    BUG: 1493975
    Signed-off-by: Atin Mukherjee <amukherj>

Comment 3 Jiffin 2017-10-13 12:46:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.2, please open a new bug report.

glusterfs-glusterfs-3.12.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-October/032684.html
[2] https://www.gluster.org/pipermail/gluster-users/