Bug 1494099

Summary: Use mariadb-connector-c-devel instead of mysql-devel or mariadb-devel
Product: [Fedora] Fedora Reporter: Michal Schorm <mschorm>
Component: mydnsAssignee: Itamar Reis Peixoto <itamar>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: acaringi, itamar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-24 17:48:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1486480    
Attachments:
Description Flags
Patch to fix build of MyDNS against MariaDB C/C 3.x none

Description Michal Schorm 2017-09-21 12:58:04 UTC
Hello, MariaDB went through big changes and your package will need a patch in order to build and work properly.

I tried to solve the issue, but I wasn't successful yet (at the time of bug creation).
I'll look into it more and post here the patch eventualy.


This change is currently applicable to the Rawhide (f28) only.


You can check builds I tried in COPR:
https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/packages/



For more information check the tracking bugzilla.

Comment 1 Augusto Caringi 2017-10-17 09:09:35 UTC
Hi,

    I'm attaching a patch with the needed modifications to build MyDNS against this new version of MariaDB Connector/C 3.x.

    The main problem is that they dropped the MYSQL_SERVER_VERSION define.

    In the spec file, we need to replace the BuildRequires: mysql-devel by BuildRequires: mariadb-connector-c-devel and add a BuildRequires: zlib-devel.

    I've already sent an email to upstream with my fix, asking if it's the best solution.

    Buildings on copr: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/build/637457/

Comment 2 Augusto Caringi 2017-10-17 09:10:59 UTC
Created attachment 1339625 [details]
Patch to fix build of MyDNS against MariaDB C/C 3.x

Comment 3 Augusto Caringi 2017-10-17 09:19:46 UTC
BTW,

    We can drop this from the spec file:

# Fix build with MariaDB 10.2
# https://bugzilla.redhat.com/show_bug.cgi?id=1470175
# http://bugs.mydns-ng.com/view.php?id=78
Patch1: mydns-mariadb102.patch

    This patch is no longer necessary.

Comment 4 Fedora End Of Life 2018-02-20 15:22:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 5 Itamar Reis Peixoto 2018-02-24 17:48:56 UTC
fixed in rawhide