Bug 1495227

Summary: Review Request: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames - Metaclass trait to attempt to demystify generated anonymous class names
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-26 06:20:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1495257    

Description Petr Pisar 2017-09-25 14:48:04 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.src.rpm
Description:
This Moose meta class role helps with creating anonymous classes.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-09-25 15:22:14 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add build-requires 'make'

$ rpm -qp --requires perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(autobox::Core)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(namespace::autoclean)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(MooseX::TraitFor::Meta::Class::BetterAnonClassNames) = 0.002003
      1 perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames = 0.002003-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames*
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.noarch: W: spelling-error Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.src: W: spelling-error Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2017-09-25 15:28:38 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames
Comment 3 Petr Pisar 2017-09-26 06:20:17 UTC 
Thank you for the review and the repository.