Bug 1495227 - Review Request: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames - Metaclass trait to attempt to demystify generated anonymous class names
Summary: Review Request: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames - Metacl...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1495257
TreeView+ depends on / blocked
 
Reported: 2017-09-25 14:48 UTC by Petr Pisar
Modified: 2017-09-26 06:20 UTC (History)
2 users (show)

Fixed In Version: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28
Clone Of:
Environment:
Last Closed: 2017-09-26 06:20:17 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Comment 1 Jitka Plesnikova 2017-09-25 15:22:14 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add build-requires 'make'

$ rpm -qp --requires perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(autobox::Core)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(namespace::autoclean)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(MooseX::TraitFor::Meta::Class::BetterAnonClassNames) = 0.002003
      1 perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames = 0.002003-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames*
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.noarch: W: spelling-error Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.src: W: spelling-error Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-09-25 15:28:38 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames

Comment 3 Petr Pisar 2017-09-26 06:20:17 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.