Bug 1495858

+++ This bug was initially created as a clone of Bug #1493893 +++

Description of problem:

When creating dispersed volume, replica 2, cli asks for confirmation even when force is give. This is a breaking change as it used to work before and even without force, although I cannot confirm this, because we don't have 3.4 anymore.


Version-Release number of selected component (if applicable):

glusterfs-3.12.1


How reproducible:

Every time/easy.


Steps to Reproduce:

gluster volume create myvolume replica 2 transport tcp host01.example.com:/brick/myvolume host02.example.com:/brick/myvolume force
Replica 2 volumes are prone to split-brain. Use Arbiter or Replica 3 to avoid this. See:  https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Split%20brain%20and%20ways%20to%20deal%20with%20it/.
Do you still want to continue?
 (y/n)

Actual results:

GlusterFS volume not created.

Expected results:

GlusterFS volume is created at least when force is given.

Additional info:

Breaking change which breaks tooling built around cli.

--- Additional comment from Atin Mukherjee on 2017-09-20 00:27:41 EDT ---

Please note that the command you have mentioned here refers to creating a replica 2 volume (not disperse one) and that's the expected behavior. We encourage users to use arbiter or replica 3 volumes instead of replica 2 and this confirmation is in place even with a force option.

--- Additional comment from Zdenek Styblik on 2017-09-20 00:42:30 EDT ---

(In reply to Atin Mukherjee from comment #1)
> Please note that the command you have mentioned here refers to creating a
> replica 2 volume (not disperse one) and that's the expected behavior. We
> encourage users to use arbiter or replica 3 volumes instead of replica 2 and
> this confirmation is in place even with a force option.

I'm sorry, but WHAT? Alright, I understand I got terminology mixed up, but you what? Are you serious? It kind of feels like #NotABugFeature to me.

Let me repeat. You've broken backwards compatibility of CLI **EVEN** when force is provided. Since you want to encourage users, why not to document it or just a print notification and link to documentation. But to add confirmation which 1. wasn't there before and breaks stuff 2. which appears even with force makes no sense to me.

Have a good day.

--- Additional comment from Atin Mukherjee on 2017-09-20 04:26:57 EDT ---

I think your concern is valid. I'm passing down this issue to the author of the patch, Karthick. Ideally the force option should bypass this validation.

@Karthick - Would you send a patch for the same?

--- Additional comment from Worker Ant on 2017-09-21 08:50:59 CEST ---

REVIEW: https://review.gluster.org/18331 (cli: Bypass the confirmation question creating replica 2 volume with force) posted (#1) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Worker Ant on 2017-09-21 14:04:25 CEST ---

REVIEW: https://review.gluster.org/18331 (cli: Bypass the confirmation question creating replica 2 volume with force) posted (#2) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Worker Ant on 2017-09-22 18:01:23 CEST ---

COMMIT: https://review.gluster.org/18331 committed in master by Atin Mukherjee (amukherj) 
------
commit f449e53df7c07301b495b4ff688d165026dfd2d0
Author: karthik-us <ksubrahm>
Date:   Thu Sep 21 12:09:12 2017 +0530

    cli: Bypass the confirmation question creating replica 2 volume with force
    
    When a replica 2 volume is created with the force option,
    remove the warning message with the confirmation question,
    whether they want to continue or not and Succeed the
    volume creation.
    
    Change-Id: I4f3306659fa4cbf53dd8d45269a32d19ce86ac88
    BUG: 1493893
    Signed-off-by: karthik-us <ksubrahm>