Bug 149588

Summary: [PATCH] Bad condition in mapping for latex2e
Product: [Fedora] Fedora Reporter: Jindrich Novy <jnovy>
Component: linuxdoc-toolsAssignee: Ondrej Vasik <ovasik>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: pknirsch, rvokal, sgrubb, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.9.21-4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-07-23 12:45:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to "mapping" file that fixes the issue.
none
Complete fix for all document classes in "mapping" and also for "tr-mapping"
none
Better patch none

Description Jindrich Novy 2005-02-24 09:32:18 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041020 Firefox/0.10.1

Description of problem:
sgml2latex generates pdf output even if --output=dvi option is passed to it. This is caused by the bad condition in mapping.

Version-Release number of selected component (if applicable):
linuxdoc-tools-0.9.21

How reproducible:
Always

Steps to Reproduce:
1. sgml2latex iproute/doc/ss.sgml
2. latex ss.tex [with teTeX-3.0]
3. output file is PDF instead of default DVI
  

Additional info:

Comment 1 Jindrich Novy 2005-02-24 09:34:00 UTC
Created attachment 111368 [details]
Patch to "mapping" file that fixes the issue.

Comment 2 Tomas Mraz 2005-02-24 15:16:44 UTC
This blocks correct rebuild of pam in RAWHIDE.


Comment 3 Tim Waugh 2005-02-24 15:36:35 UTC
This fix is incomplete.  \ifpdf is used elsewhere in that file.

Comment 4 Tim Waugh 2005-02-24 15:39:05 UTC
I've checked in a more complete fix -- please try 0.9.21-2.

Comment 5 Jindrich Novy 2005-02-24 16:06:43 UTC
Tim, I just noticed that when testing it on pam. I've done a more complete fix.
I'll attach it also here.

Comment 6 Jindrich Novy 2005-02-24 16:11:35 UTC
Created attachment 111382 [details]
Complete fix for all document classes in "mapping" and also for "tr-mapping"

Comment 7 Tim Waugh 2005-02-24 16:37:37 UTC
Applied and built as 0.9.21-3.

Comment 8 Tomas Mraz 2005-02-24 17:27:55 UTC
This is not right. The \ifx\pdfoutput\defined doesn't test for definition of
\pdfoutput, it's actually exactly the same as \ifx\pdfoutput\undefined. You've
just simply inverted the if condition and thus it will not generate pdf output
correctly. It will generate it but the conditions will not be evaluated as true
so the output will be different.


Comment 9 Tomas Mraz 2005-02-24 17:38:41 UTC
Created attachment 111388 [details]
Better patch

This patch will work with both old and new tetex versions.

Comment 10 Tim Waugh 2005-02-24 17:46:43 UTC
Thanks.  Okay, built as 0.9.21-4.

Comment 11 Radek Vokál 2005-02-25 09:23:09 UTC
Fixes my problem with iproute build. Thanks

Comment 12 Jindrich Novy 2005-06-03 06:50:53 UTC
Tim, this problem is well known in upstream as well an they suggest the
following solution to this issue:

\ifx\pdfoutput\undefined
  <not running PDFTeX>
\else
  \ifx\pdfoutput\relax
    <not running PDFTeX>
  \else
    <running PDFTeX, with...>
    \ifnum\pdfoutput>0
      <...PDF output>
    \else
      <...DVI output>
    \fi
  \fi
\fi

Comment 13 Ondrej Vasik 2007-07-23 12:45:40 UTC
Closing as CURRENTRELEASE.