Bug 1496760
Summary: | openshift_health_check is doing "docker_storage" against a NFS host | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Johnny Liu <jialiu> |
Component: | Installer | Assignee: | Luke Meyer <lmeyer> |
Status: | CLOSED ERRATA | QA Contact: | Johnny Liu <jialiu> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 3.7.0 | CC: | aos-bugs, jokerman, mmccomas |
Target Milestone: | --- | ||
Target Release: | 3.7.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | No Doc Update | |
Doc Text: |
undefined
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2017-11-28 22:13:20 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Johnny Liu
2017-09-28 10:11:06 UTC
The short story is that with containerized=true in your inventory, openshift-ansible will treat every host as if it needs docker installed, even if it's nfs or lb. If you mark the individual hosts that do not need this with containerized=false then this will not happen. This is true of the docker role, independently of this check (I see you reported https://bugzilla.redhat.com/show_bug.cgi?id=1497144 which is possibly a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1429371) so you could argue that the check is correct. Really, though, the logic should be such that we never do anything with docker on systems for components that can't be containerized. And for that matter, for this inventory, the logic needs to take into account that containerized components should be a system container anyway and not rely on docker. So there is a bug here, it should be improved. Ideally the logic would go in the docker role and the docker checks would just consult the outcome to determine whether and how to run. https://github.com/openshift/openshift-ansible/pull/5658 (Note, https://github.com/openshift/openshift-ansible/pull/5636 fixes the installer logic) Commit pushed to master at https://github.com/openshift/openshift-ansible https://github.com/openshift/openshift-ansible/commit/776b0d9478d92c11c5dd285c758ffae668674f8e openshift_checks: lb and nfs do not need docker fixes bug 1496760 https://bugzilla.redhat.com/show_bug.cgi?id=1496760 Verified this bug with openshift-ansible-3.7.0-0.148.0.git.0.b35eb14.el7.noarch, and PASS. Trigger a containerized install with global containerized=true in inventory host file, the env is including 1 master + 1 node + 1 nfs, no "docker_storage" health_check is run against NFS host. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:3188 |